Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Towards crypto & method agility: API updates, new buffer, new credential struct #284

Merged
merged 31 commits into from
Aug 2, 2024
Merged

Towards crypto & method agility: API updates, new buffer, new credential struct #284

merged 31 commits into from
Aug 2, 2024

Conversation

geonnave
Copy link
Collaborator

@geonnave geonnave commented Jun 4, 2024

Still very early stage.

@geonnave geonnave force-pushed the crypto-method-agility branch 2 times, most recently from 038b6da to c873923 Compare June 5, 2024 15:59
@chrysn chrysn mentioned this pull request Jun 21, 2024
Closed
@geonnave geonnave mentioned this pull request Jun 21, 2024
Merged
@geonnave geonnave mentioned this pull request Jul 1, 2024
Merged
@geonnave
Copy link
Collaborator Author

So far this PR includes:

  • updates in the API
    • support for setting different methods and crypto suites (even though only one is supported for now)
    • a separate function for setting identity (private key + credential)
  • a new buffer struct that is parameterizeable via const generics
  • a new credential struct that supports CCS's that hold asymmetric and symmetric keys
  • improved handling of ID_CRED_x, including support for kids longer than 1 byte

Next steps are to update the examples and C/Python wrappers, then merge on main and continue the agility work on a new PR.

@geonnave geonnave marked this pull request as ready for review July 31, 2024 09:19
geonnave and others added 20 commits July 31, 2024 11:54
@geonnave
crypto: new function to construct suites_i
d103a22
@geonnave
feat: add EdhocBuffer
333c7ed
@geonnave
crypto: use EdhocBuffer for suites
639fa7c
@geonnave
feat: refactor suites_i into EdhocBuffer
4c8494b
@geonnave
fix(hax): no mutable refs in loops
f0df4e5
@geonnave
agility: update c and python (no api change)
8e926b0
@geonnave
agility: chores for psa and authz test
fe66684
@geonnave
agility: allow early or late set_identity
895693a
@geonnave
agility: adjust api on responder side
4e4aac3
@geonnave
creds: new more versatile credentials module
52bca5b 
will support more types of credentials,
     including different types of COSE_Key's

the handling of id_cred's is inspired by chrysn's PR openwsn-berkeley#274
@geonnave
creds: updates on new cred module
79660ca
@geonnave
creds: refactor into simpler structs
1b0a32d
@geonnave
creds: add parse methods
97db44d
@ElsaLopez133 @geonnave
Implement parse_ccs_psk
1c14779
@ElsaLopez133 @geonnave
creds: Correcting parse_css_psk
b7a819d
@ElsaLopez133 @geonnave
creds(WIP): implement parse_ccs_psk
13a752a
@geonnave
creds: simplify api and add tests
8559890
@geonnave
creds: use new struct for IdCred
04c7310 
borrowing code from @chrysn's PR openwsn-berkeley#274
@geonnave
creds: new id_cred struct improvements
95fb363
@geonnave
creds: apply new id_cred struct across codebase
9f91594
@geonnave geonnave changed the title Add crypto & method agility Towards crypto & method agility: API updates, new buffer, new credential strucr Aug 2, 2024
@geonnave geonnave changed the title Towards crypto & method agility: API updates, new buffer, new credential strucr Towards crypto & method agility: API updates, new buffer, new credential struct Aug 2, 2024
@geonnave geonnave requested a review from malishav August 2, 2024 08:52
@geonnave
Copy link
Collaborator Author

geonnave commented Aug 2, 2024

@malishav just asked for a review, mostly interested in an ack about the changeset (in comment above).

One point I have is that the Symmetric key type would not need to live in main, but not keeping it in main means having to keep another version of the code just for that, which in my opinion is not worth it.

@geonnave
Copy link
Collaborator Author

geonnave commented Aug 2, 2024

Also, regarding actual crypto agility, I will leave for another PR since this one is already big enough...

malishav
malishav approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@malishav malishav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went briefly over the PR, it is massive, congrats on pulling this off! I am happy if you merge this!

@geonnave geonnave merged commit b82451d into openwsn-berkeley:main Aug 2, 2024
31 checks passed
@geonnave geonnave deleted the crypto-method-agility branch August 2, 2024 11:36
This was referenced Aug 2, 2024
Closed
Closed
@chrysn chrysn mentioned this pull request Aug 16, 2024
Open
@malishav malishav mentioned this pull request Aug 28, 2024
Closed
geonnave added a commit to geonnave/lakers that referenced this pull request Oct 4, 2024
@geonnave
release: bump version to 0.7.0
a216c24 
includes breaking changes from PRs openwsn-berkeley#284 and openwsn-berkeley#294
@geonnave geonnave mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malishav malishav malishav approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geonnave @malishav @ElsaLopez133