Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sdist packages usable #290

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

chrysn
Copy link
Collaborator

@chrysn chrysn commented Jun 23, 2024

Closes: #289

@chrysn chrysn force-pushed the usable-sdist branch 3 times, most recently from 2834fa2 to e9944be Compare June 23, 2024 14:46
@chrysn chrysn marked this pull request as ready for review June 23, 2024 14:46
@chrysn
Copy link
Collaborator Author

chrysn commented Jun 23, 2024

I think this is ready for review; it passes CI.

Changes apart from "fixing the issue" are:

  • On the platform that builds the sdist, also build the binaries from the sdist. (It'd be nice to build all from the sdist, but that'd create complex interactions, and chances are that that orthogonal niche doesn't attract bugs).
  • CI runs Python tests now on every PR, helping spot similar issues early when more crates are added.

After this got merged, please consider adding the "build python wheels" check(s) to the mandatory list for merging.

@geonnave
Copy link
Collaborator

adding ... to mandatory list for merging

According to this, I may not have permission to do that (seems to require organisation's owner permission). cc @malishav.

@chrysn
Copy link
Collaborator Author

chrysn commented Jun 23, 2024

There's no hurry with that: having those builds visible and non-blocking would still be an improvement.

This ensures that they are useable for a full build.
This is the only regular testing we get on exotic platforms (Windows,
MacOS), and it helps spot changes in the manifest Cargo.toml that only
manifest during Python builds.
@geonnave geonnave merged commit 6af24b7 into openwsn-berkeley:main Jun 23, 2024
31 checks passed
@chrysn chrysn deleted the usable-sdist branch June 23, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lakers-python: Fails to build from dist tarball (at least on Python 3.13)
2 participants