-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add yurtadm to install/uninstall staticpod #1550
add yurtadm to install/uninstall staticpod #1550
Conversation
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
+ Coverage 50.85% 51.10% +0.24%
==========================================
Files 133 133
Lines 15852 15722 -130
==========================================
- Hits 8062 8035 -27
+ Misses 7045 6952 -93
+ Partials 745 735 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8ce616c
to
c7788a1
Compare
@YTGhost PTAL |
@JameKeal How about make a pull request to update yurtadm docs in the homepage website? |
OK, I'll take a time to update it. |
a12b219
to
356a866
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JameKeal, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
It is very hard for user to install/uninstall static pods on node manually, and we should install/uninstall static pods based on YurtStaticSet resource. so we need add the above features.
Which issue(s) this PR fixes:
Fixes #1472
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note