Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yurtadm to install/uninstall staticpod #1550

Merged

Conversation

JameKeal
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

It is very hard for user to install/uninstall static pods on node manually, and we should install/uninstall static pods based on YurtStaticSet resource. so we need add the above features.

Which issue(s) this PR fixes:

Fixes #1472

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

It is very hard for user to install/uninstall static pods on node manually, and we should install/uninstall static pods based on YurtStaticSet resource. so we need add the above features.

Which issue(s) this PR fixes:

Fixes #1472

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Jun 16, 2023
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1550 (a12b219) into master (c3cf90b) will increase coverage by 0.24%.
The diff coverage is 60.27%.

❗ Current head a12b219 differs from pull request most recent head 356a866. Consider uploading reports for the commit 356a866 to get more accurate results

@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
+ Coverage   50.85%   51.10%   +0.24%     
==========================================
  Files         133      133              
  Lines       15852    15722     -130     
==========================================
- Hits         8062     8035      -27     
+ Misses       7045     6952      -93     
+ Partials      745      735      -10     
Flag Coverage Δ
unittests 51.10% <60.27%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurtadm/cmd/join/join.go 57.19% <24.24%> (-3.86%) ⬇️
pkg/yurtadm/util/edgenode/edgenode.go 31.57% <88.23%> (+19.45%) ⬆️
pkg/yurtadm/util/yurthub/yurthub.go 31.65% <100.00%> (+3.08%) ⬆️

... and 8 files with indirect coverage changes

@openyurt-bot openyurt-bot added size/XL size/XL: 500-999 and removed size/L size/L: 100-499 labels Jun 16, 2023
@JameKeal JameKeal force-pushed the support-install-uninstall-staticpod branch from 8ce616c to c7788a1 Compare June 16, 2023 10:08
@rambohe-ch
Copy link
Member

@YTGhost PTAL

@YTGhost
Copy link
Member

YTGhost commented Jun 19, 2023

@JameKeal How about make a pull request to update yurtadm docs in the homepage website?

@JameKeal
Copy link
Member Author

@JameKeal How about make a pull request to update yurtadm docs in the homepage website?

OK, I'll take a time to update it.

@JameKeal JameKeal force-pushed the support-install-uninstall-staticpod branch from a12b219 to 356a866 Compare June 19, 2023 03:47
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JameKeal JameKeal requested a review from YTGhost June 19, 2023 06:11
Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@YTGhost
Copy link
Member

YTGhost commented Jun 19, 2023

@JameKeal How about make a pull request to update yurtadm docs in the homepage website?

OK, I'll take a time to update it.

@JameKeal The documentation for yurtadm is automatically generated using the yurtadm docs command. An example of modifying the yurtadm documentation can be found in this PR :)

@rambohe-ch
Copy link
Member

/approve

@openyurt-bot openyurt-bot added the approved approved label Jun 19, 2023
@openyurt-bot openyurt-bot merged commit 477b59d into openyurtio:master Jun 19, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JameKeal JameKeal deleted the support-install-uninstall-staticpod branch June 20, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]support install/uninstall static pods on nodes
4 participants