Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yurtadm binaries release workflow #1577

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

add a workflow for release yurtadm binaries as assets when a version is released.

Which issue(s) this PR fixes:

Fixes #1085

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

add a workflow for release yurtadm binaries as assets when a version is released.

Which issue(s) this PR fixes:

Fixes #1085

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added kind/feature kind/feature size/M size/M: 30-99 labels Jul 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #1577 (3c8e6d5) into master (211cb4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1577   +/-   ##
=======================================
  Coverage   51.43%   51.43%           
=======================================
  Files         134      134           
  Lines       15947    15947           
=======================================
  Hits         8202     8202           
  Misses       7000     7000           
  Partials      745      745           
Flag Coverage Δ
unittests 51.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kadisi
Copy link
Member

kadisi commented Jul 3, 2023

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadisi, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit 41647c4 into openyurtio:master Jul 4, 2023
@rambohe-ch rambohe-ch added backport release-v1.2 backport release-v1.2 backport release-v1.3 backport release-v1.3 labels Jul 4, 2023
@rambohe-ch
Copy link
Member Author

/backport release-v1.2

@rambohe-ch
Copy link
Member Author

/backport release-v1.3

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Git push to origin failed for release-v1.2 with exitcode 1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Successfully created backport PR for release-v1.3:

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Git push to origin failed for release-v1.2 with exitcode 1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Git push to origin failed for release-v1.3 with exitcode 1

@rambohe-ch
Copy link
Member Author

/backport release-v1.0

@github-actions
Copy link

Git push to origin failed for release-v1.0 with exitcode 1

@github-actions
Copy link

Git push to origin failed for release-v1.2 with exitcode 1

@github-actions
Copy link

Backport failed for release-v1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.3
git worktree add -d .worktree/backport-1577-to-release-v1.3 origin/release-v1.3
cd .worktree/backport-1577-to-release-v1.3
git checkout -b backport-1577-to-release-v1.3
ancref=$(git merge-base 211cb4f08b33baaf3da83d04f3f0f4a2447dcb3c 3c8e6d5b2d150af0f0fafd2aa95a69623b495557)
git cherry-pick -x $ancref..3c8e6d5b2d150af0f0fafd2aa95a69623b495557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved backport release-v1.0 backport release-v1.0 backport release-v1.2 backport release-v1.2 backport release-v1.3 backport release-v1.3 kind/feature kind/feature lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]add yurtadm binary into assets automatically when release openyurt new version.
4 participants