Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change access permission to default in general. #1598

Merged
merged 1 commit into from
Jul 11, 2023
Merged

change access permission to default in general. #1598

merged 1 commit into from
Jul 11, 2023

Conversation

fujitatomoya
Copy link
Contributor

backport of #1576 for release-v1.1

What type of PR is this?

/kind bug

@fujitatomoya
change access permission to default in general.
78e997a 
  backport of openyurtio#1576 for release-v1.1

Signed-off-by: Tomoya Fujita <[email protected]>
@openyurt-bot openyurt-bot added the kind/bug kind/bug label Jul 10, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fujitatomoya
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jul 10, 2023
fujitatomoya
fujitatomoya commented Jul 10, 2023
View reviewed changes
Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, requesting maintainer review.

@fujitatomoya fujitatomoya mentioned this pull request Jul 10, 2023
Merged
YTGhost
YTGhost reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Jul 10, 2023
@fujitatomoya
Copy link
Contributor Author

https://sonarcloud.io/project/issues?id=openyurtio_openyurt&pullRequest=1598&resolved=false&types=CODE_SMELL is unrelated to the fix.

@rambohe-ch friendly ping.

@rambohe-ch rambohe-ch merged commit f5563f7 into openyurtio:release-v1.1 Jul 11, 2023
@open-digger-bot open-digger-bot bot mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YTGhost YTGhost YTGhost left review comments

@Peeknut Peeknut Awaiting requested review from Peeknut

@zzguang zzguang Awaiting requested review from zzguang

Assignees

@YTGhost YTGhost

Labels
kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fujitatomoya @openyurt-bot @YTGhost @rambohe-ch