-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reclaim device, deviceprofile and deviceservice before exiting YurtIoTDock #1647
Conversation
Signed-off-by: wangxye <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/assign |
Codecov Report
@@ Coverage Diff @@
## master #1647 +/- ##
=======================================
Coverage 51.66% 51.66%
=======================================
Files 145 145
Lines 17011 17011
=======================================
Hits 8788 8788
Misses 7407 7407
Partials 816 816
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it on my own cluster and still couldn't seem to destroy the crd on exit.
kubectl get po
NAME READY STATUS RESTARTS AGE
yurt-manager-5b8b997644-g8hhx 1/1 Running 0 6m44s
kubectl get device
NAME NODEPOOL SYNCED AGE
beijing-random-binary-device beijing true 64s
beijing-random-boolean-device beijing true 64s
beijing-random-float-device beijing true 64s
beijing-random-integer-device beijing true 64s
beijing-random-unsignedinteger-device beijing true 64s
beijing-sample-image beijing true 64s
beijing-sample-json beijing true 64s
beijing-sample-numeric beijing true 64s
...
@wangxye Sorry, it's the problem with my local shell workflow. The pr test should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@LavenderQAQ: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LavenderQAQ, rambohe-ch, wangxye The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
/sig iot
What this PR does / why we need it:
When YurtIoTDock receives the exit signal, it needs to reclaim device, deviceprofile, and deviceservice.
Clean up unwanted cr for users.
Which issue(s) this PR fixes:
Fixes #1626
Does this PR introduce a user-facing change?