Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reclaim device, deviceprofile and deviceservice before exiting YurtIoTDock #1647

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

wangxye
Copy link
Member

@wangxye wangxye commented Aug 11, 2023

What type of PR is this?

/kind feature
/sig iot

What this PR does / why we need it:

When YurtIoTDock receives the exit signal, it needs to reclaim device, deviceprofile, and deviceservice.
Clean up unwanted cr for users.

Which issue(s) this PR fixes:

Fixes #1626

Does this PR introduce a user-facing change?

NONE

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Aug 11, 2023
@openyurt-bot openyurt-bot added the sig/iot sig/iot label Aug 11, 2023
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Aug 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LavenderQAQ
Copy link
Member

/assign

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1647 (8bac380) into master (d89a805) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1647   +/-   ##
=======================================
  Coverage   51.66%   51.66%           
=======================================
  Files         145      145           
  Lines       17011    17011           
=======================================
  Hits         8788     8788           
  Misses       7407     7407           
  Partials      816      816           
Flag Coverage Δ
unittests 51.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@LavenderQAQ LavenderQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on my own cluster and still couldn't seem to destroy the crd on exit.

kubectl get po
NAME                            READY   STATUS    RESTARTS   AGE
yurt-manager-5b8b997644-g8hhx   1/1     Running   0          6m44s
kubectl get device
NAME                                    NODEPOOL   SYNCED   AGE
beijing-random-binary-device            beijing    true     64s
beijing-random-boolean-device           beijing    true     64s
beijing-random-float-device             beijing    true     64s
beijing-random-integer-device           beijing    true     64s
beijing-random-unsignedinteger-device   beijing    true     64s
beijing-sample-image                    beijing    true     64s
beijing-sample-json                     beijing    true     64s
beijing-sample-numeric                  beijing    true     64s
...

@LavenderQAQ
Copy link
Member

@wangxye Sorry, it's the problem with my local shell workflow. The pr test should be fine.

Copy link
Member

@LavenderQAQ LavenderQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LavenderQAQ, rambohe-ch, wangxye

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 14, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Aug 14, 2023
@openyurt-bot openyurt-bot merged commit 2ed7f0f into openyurtio:master Aug 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm sig/iot sig/iot size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Reclaim device, deviceprofile and deviceservice before exiting YurtIoTDock
4 participants