Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yurt express: openyurt data transmission system proposal #1840

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

qsfang
Copy link
Contributor

@qsfang qsfang commented Dec 5, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add proposal for supporting edge data tunnel with openyurt

Special notes for your reviewer:

@rambohe-ch
Copy link
Member

@qsfang please fix the markdown lint errors.

@qsfang
Copy link
Contributor Author

qsfang commented Dec 6, 2023

edge data tunnel will be a new project under openyurt, and it needs a new name.
ChatGPT offers me some options, and i prefer "yurtward", which means directed or moving towards a yurt.


"Yurtward" is an adverb that describes a direction or movement towards a yurt. For example, "They walked yurtward, eager to reach their cozy yurt in the campsite." It indicates the orientation or destination in relation to a yurt.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qsfang
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4147dd6) 52.19% compared to head (8d6e62e) 52.19%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1840   +/-   ##
=======================================
  Coverage   52.19%   52.19%           
=======================================
  Files         172      172           
  Lines       20825    20839   +14     
=======================================
+ Hits        10869    10877    +8     
- Misses       8994     8998    +4     
- Partials      962      964    +2     
Flag Coverage Δ
unittests 52.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qsfang
Copy link
Contributor Author

qsfang commented Dec 12, 2023

@qsfang please fix the markdown lint errors.

@rambohe-ch markdown lint issues are fixed, need review

@qsfang
Copy link
Contributor Author

qsfang commented Dec 12, 2023

/assign @rambohe-ch

@rambohe-ch
Copy link
Member

/rerun

@qsfang qsfang changed the title add edge data tunnel proposal yurt express: openyurt data transmission system proposal Dec 25, 2023
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@qsfang
Copy link
Contributor Author

qsfang commented Dec 25, 2023

@rambohe-ch pls review, optimized according to weekly meeting discussion
Project name rename to "yurt-express"
Additionally, add YurtExpressChannel CRD to define user channel, and original configmap channel definition is deprecated.For user configuration simplicity and future cloud-edge, edge-edge data transition extension implementation

@rambohe-ch
Copy link
Member

@rambohe-ch pls review, optimized according to weekly meeting discussion Project name rename to "yurt-express" Additionally, add YurtExpressChannel CRD to define user channel, and original configmap channel definition is deprecated.For user configuration simplicity and future cloud-edge, edge-edge data transition extension implementation

@qsfang It seems that YurtExpressChannel CRD is a good idea for user to configure the settings of transmit tunnel.

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch merged commit 5c1dde7 into openyurtio:master Dec 26, 2023
13 checks passed
@qsfang qsfang deleted the edge-data-tunnel-proposal branch January 3, 2024 10:08
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants