feat: improve discardcloudservice filter in yurthub component (#1924)

[huangchenzhao]

What type of PR is this?

/kind feature

What this PR does / why we need it:

have improved discardcloudservice filter in yurthub component

only discarding LoadBalancer service which has annotation svc.openyurt.io/discard=true, instead of which doesn't have openyurt.io/skip-discard=true.

Which issue(s) this PR fixes:

Fixes #1924

[huangchenzhao]

It seems unit tests in 'discardcloudservice filter' should be modified to ensure synchronization with the changed code, I will fix it soon.

[rambohe-ch]

It seems unit tests in 'discardcloudservice filter' should be modified to ensure synchronization with the changed code, I will fix it soon.

yes, unit tests also should be tuned.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81d21b7) 52.16% compared to head (e651e7d) 52.19%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1926      +/-   ##
==========================================
+ Coverage   52.16%   52.19%   +0.02%     
==========================================
  Files         172      173       +1     
  Lines       20874    21117     +243     
==========================================
+ Hits        10888    11021     +133     
- Misses       9018     9120     +102     
- Partials      968      976       +8     

Flag	Coverage Δ
unittests	52.19% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[huangchenzhao]

It seems unit tests in 'discardcloudservice filter' should be modified to ensure synchronization with the changed code, I will fix it soon.

yes, unit tests also should be tuned.

fixed unit tests.

[rambohe-ch]

/rerun

[huangchenzhao]

/rerun

[huangchenzhao]

/rerun

[rambohe-ch]

/lgtm