Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use node bucket to support pool service topology filter in yurthub #1930

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Node Bucket controller had been completed in the pull request #1874 , then yurthub component should be improved to use NodeBucket to support service topology feature.

and this pull request is posted for this feature.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

1. `--enable-pool-service-topology` parameter is newly added in yurthub, and this parameter is used for enabling or disabling service topology feature in the nodepool. at the same time, this parameter can not effect the service topology feature on the node level.
2. `--enable-node-pool` parameter is deprecated in yurthub, because NodeBucket is used for supporting service topology feature, and this parameter will be removed in the future, so `--enable-pool-service-topology` is recommended to use from OpenYurt v1.5 version.
3. For compatibility with OpenYurt v1.4, NodePool is used by default to support service topology feature, so default value of `--enable-pool-service-topology` is false, and `--enable-node-pool` is true.

other Note

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (3dd6c5c) 52.23% compared to head (dc88a34) 52.04%.
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/yurthub/filter/initializer/nodesInitializer.go 0.00% 82 Missing ⚠️
...ger/controller/nodebucket/nodebucket_controller.go 0.00% 16 Missing ⚠️
cmd/yurthub/app/config/config.go 25.00% 8 Missing and 1 partial ⚠️
pkg/yurthub/filter/servicetopology/filter.go 82.05% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1930      +/-   ##
==========================================
- Coverage   52.23%   52.04%   -0.20%     
==========================================
  Files         173      174       +1     
  Lines       21117    21213      +96     
==========================================
+ Hits        11031    11040       +9     
- Misses       9110     9199      +89     
+ Partials      976      974       -2     
Flag Coverage Δ
unittests 52.04% <27.38%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JameKeal JameKeal merged commit 612864a into openyurtio:master Jan 23, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants