Add missing verb to the role of node lifecycle controller #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1936 +/- ##
=======================================
Coverage 52.04% 52.04%
=======================================
Files 174 174
Lines 21213 21213
=======================================
Hits 11040 11040
Misses 9199 9199
Partials 974 974
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@crazytaxii charts/yurt-manager/crds/apiextensions.k8s.io_v1_customresourcedefinition_blockaffinities.apiregistration.k8s.io.yaml file need to be ignored. |
Signed-off-by: HF <[email protected]>
|
|
/lgtm |
rambohe-ch
approved these changes
Jan 31, 2024
zyjhtangtang
pushed a commit
to zyjhtangtang/openyurt
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Node lifecycle controller in yurt-manager maybe miss rbac settings.
Which issue(s) this PR fixes:
Fixes #1934
Does this PR introduce a user-facing change?