fix: deployment render should only mutate workloads created by yurtap… #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1974 +/- ##
=======================================
Coverage 52.41% 52.41%
=======================================
Files 173 173
Lines 21015 21018 +3
=======================================
+ Hits 11014 11017 +3
Misses 9051 9051
Partials 950 950
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
@vie-serendipity Thank you for posting the pull request to improve YurtAppSet workload. I agree with you that deployment render webhook should effect v1alpha1.YurtAppSet only. |
rambohe-ch
approved these changes
Mar 13, 2024
|
/lgtm |
vie-serendipity
added a commit
to vie-serendipity/openyurt
that referenced
this pull request
Mar 20, 2024
openyurtio#1974) * fix: deployment render should only mutate workloads created by yurtappset v1alpha1
zyjhtangtang
pushed a commit
to zyjhtangtang/openyurt
that referenced
this pull request
Apr 16, 2024
openyurtio#1974) * fix: deployment render should only mutate workloads created by yurtappset v1alpha1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pset v1alpha1
What type of PR is this?
/kind bug
What this PR does / why we need it:
Yurtappset is updated to v1beta1. Now deployment render will mutate all workloads created by yurtappset. Actually, yurtappoverrider should only manage workloads created by yurtappset v1alpha1. Otherwise, it will cause unexpected errors. So we should add some restrictions to deployment webhook of yurtappoverrider.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note