return back watch.Deleted event to clients when watch object is removed in OjbectFilters #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1995 +/- ##
==========================================
+ Coverage 53.03% 53.05% +0.02%
==========================================
Files 176 176
Lines 20929 20944 +15
==========================================
+ Hits 11099 11112 +13
- Misses 8882 8884 +2
Partials 948 948
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Congrool
reviewed
Mar 26, 2024
|
lgtm, but I still have questions for some of the modifications. @rambohe-ch PTAL |
rambohe-ch
force-pushed
the
nodeport-isolation-dev
branch
from
1664d99
to
0773528
Compare
|
|
@Congrool I have fixed you comments, PTAL |
|
/rerun |
|
/approve |
Congrool
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
ResponseFilter return
watch.Deletedevent back to clients when Standalone object is filtered to nil in ObjectFilters.by the way, this feature will be helpful for all ObjectFilters, not only for
nodeportisolationfilter.Which issue(s) this PR fixes:
Fixes #1994
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note