-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add forwardkubesvctraffic filter and adapt server certificate #1996
add forwardkubesvctraffic filter and adapt server certificate #1996
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1996 +/- ##
==========================================
+ Coverage 53.08% 53.11% +0.02%
==========================================
Files 175 176 +1
Lines 20910 21000 +90
==========================================
+ Hits 11100 11154 +54
- Misses 8861 8892 +31
- Partials 949 954 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/rerun |
e2e failed when preparing environment for autonomy test
/rerun |
{ | ||
Addresses: []string{fkst.host}, | ||
Conditions: discovery.EndpointConditions{ | ||
Ready: &trueCondition, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to replace it with following:
Ready: pointer.Bool(true)
which in pkg "k8s.io/utils/pointer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems not updated? @rambohe-ch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the definition of trueCondition
is improved by pointer.Bool(true)
.
/lgtm |
8e60ce3
to
9f157d9
Compare
Quality Gate passedIssues Measures |
/rerun |
e2e test error log:
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
add a new ObjectFilter named
forwardkubesvctraffic
in order to improve transparent management mechanism for control traffic from edge to cloud.the detail design of this filter, the proposal link is here: #1975
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note