Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forwardkubesvctraffic filter and adapt server certificate #1996

Merged

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

add a new ObjectFilter named forwardkubesvctraffic in order to improve transparent management mechanism for control traffic from edge to cloud.

the detail design of this filter, the proposal link is here: #1975

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 51.57895% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 53.11%. Comparing base (b4cfa75) to head (9f157d9).

Files Patch % Lines
pkg/yurthub/certificate/server/server.go 19.51% 32 Missing and 1 partial ⚠️
pkg/yurthub/filter/forwardkubesvctraffic/filter.go 75.47% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1996      +/-   ##
==========================================
+ Coverage   53.08%   53.11%   +0.02%     
==========================================
  Files         175      176       +1     
  Lines       20910    21000      +90     
==========================================
+ Hits        11100    11154      +54     
- Misses       8861     8892      +31     
- Partials      949      954       +5     
Flag Coverage Δ
unittests 53.11% <51.57%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YTGhost
Copy link
Member

YTGhost commented Mar 26, 2024

/rerun

@Congrool
Copy link
Member

e2e failed when preparing environment for autonomy test

+ kubectl wait --for=condition=Ready pod/yurt-e2e-test-nginx-openyurt-e2e-test-worker --timeout=240s
Error from server (NotFound): pods "yurt-e2e-test-nginx-openyurt-e2e-test-worker" not found
make: *** [Makefile:114: e2e-tests] Error 1
Error: Process completed with exit code 2.

/rerun

{
Addresses: []string{fkst.host},
Conditions: discovery.EndpointConditions{
Ready: &trueCondition,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to replace it with following:

    Ready: pointer.Bool(true)

which in pkg "k8s.io/utils/pointer"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems not updated? @rambohe-ch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the definition of trueCondition is improved by pointer.Bool(true).

@Congrool
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch force-pushed the add-forwardkubesvctraffic-filter branch from 8e60ce3 to 9f157d9 Compare March 29, 2024 02:02
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@Congrool
Copy link
Member

/rerun

@Congrool
Copy link
Member

e2e test error log:

+ kubectl wait --for=condition=Ready pod/yurt-e2e-test-nginx-openyurt-e2e-test-worker --timeout=240s
Error from server (NotFound): pods "yurt-e2e-test-nginx-openyurt-e2e-test-worker" not found
make: *** [Makefile:114: e2e-tests] Error 1
Error: Process completed with exit code 2.

@Congrool Congrool merged commit 56b874c into openyurtio:master Mar 29, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants