Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pool service controller. #2010

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

zyjhtangtang
Copy link
Contributor

What type of PR is this?

/kind feature
/sig network

What this PR does / why we need it:

The first-level controller for the multi-region load balancer.

Does this PR introduce a user-facing change?

YES

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 73.75000% with 147 lines in your changes are missing coverage. Please review.

Project coverage is 55.24%. Comparing base (839a52a) to head (1df5657).
Report is 1 commits behind head on master.

Files Patch % Lines
...rset/loadbalancerset/loadbalancerset_controller.go 65.88% 60 Missing and 27 partials ⚠️
...oller/loadbalancerset/loadbalancerset/predicate.go 75.38% 16 Missing and 16 partials ⚠️
...ler/loadbalancerset/loadbalancerset/annotations.go 79.48% 8 Missing and 8 partials ⚠️
...r/loadbalancerset/loadbalancerset/event_handler.go 83.56% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
+ Coverage   54.71%   55.24%   +0.53%     
==========================================
  Files         177      183       +6     
  Lines       17271    17831     +560     
==========================================
+ Hits         9450     9851     +401     
- Misses       6849     6953     +104     
- Partials      972     1027      +55     
Flag Coverage Δ
unittests 55.24% <73.75%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyjhtangtang
Copy link
Contributor Author

/rerun

@rambohe-ch
Copy link
Member

@zyjhtangtang I think the repo of controllers about MultiPoolLoadBalancer should be constructed as following:

controller:
|
-- loadbalancerset:
   |
   -- loadbalancerset:
   |
   -- enslb:
   | 
   -- viplb:

@zyjhtangtang
Copy link
Contributor Author

@zyjhtangtang I think the repo of controllers about MultiPoolLoadBalancer should be constructed as following:

controller:
|
-- loadbalancerset:
   |
   -- loadbalancerset:
   |
   -- enslb:
   | 
   -- viplb:

Thanks for the suggestion, I have adjusted the relevant directory structure

Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Apr 12, 2024
@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch merged commit 20594f8 into openyurtio:master Apr 12, 2024
13 checks passed
zyjhtangtang added a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants