Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix only openyurt crd conversion should be handled for upgrading cert #2013

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind bug

What this PR does / why we need it:

yurt-manager component only handle CRD resource of OpenYurt project, because certificates of other components will be effected.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@rambohe-ch rambohe-ch added the kind/bug kind/bug label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.71%. Comparing base (c137221) to head (10313f7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2013   +/-   ##
=======================================
  Coverage   54.71%   54.71%           
=======================================
  Files         177      177           
  Lines       17271    17271           
=======================================
  Hits         9450     9450           
  Misses       6849     6849           
  Partials      972      972           
Flag Coverage Δ
unittests 54.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Congrool
Copy link
Member

/lgtm
/approve

@Congrool Congrool added approved approved lgtm lgtm labels Apr 10, 2024
@Congrool Congrool merged commit 682fd01 into openyurtio:master Apr 10, 2024
13 checks passed
@rambohe-ch rambohe-ch added the backport release-v1.4 backport release-v1.4 label Apr 10, 2024
@rambohe-ch
Copy link
Member Author

/backport release-v1.4

Copy link

Successfully created backport PR for release-v1.4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved backport release-v1.4 backport release-v1.4 kind/bug kind/bug lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants