-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BRT: Fix FICLONE/FICLONERANGE shortened copy
On Linux the ioctl_ficlonerange() and ioctl_ficlone() system calls are expected to either fully clone the specified range or return an error. The range may be for an entire file. While internally ZFS supports cloning partial ranges there's no way to return the length cloned to the caller so we need to make this all or nothing. As part of this change support for the REMAP_FILE_CAN_SHORTEN flag has been added. When REMAP_FILE_CAN_SHORTEN is set zfs_clone_range() will return a shortened range when encountering pending dirty records. When it's clear zfs_clone_range() will block and wait for the records to be written out allowing the blocks to be cloned. Furthermore, the file rangelock is held over the region being cloned to prevent it from being modified while cloning. This doesn't quite provide an atomic semantics since if an error is encountered only a portion of the range may be cloned. This will be converted to an error if REMAP_FILE_CAN_SHORTEN was not provided and returned to the caller. However, the destination file range is left in an undefined state. A test case has been added which exercises this functionality by verifying that `cp --reflink=never|auto|always` works correctly. Signed-off-by: Brian D Behlendorf <[email protected]> Issue #15728
- Loading branch information
1 parent
2e6b3c4
commit c5a762f
Showing
11 changed files
with
222 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
159 changes: 159 additions & 0 deletions
159
tests/zfs-tests/tests/functional/cp_files/cp_files_002_pos.ksh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| #! /bin/ksh -p | ||
| # | ||
| # CDDL HEADER START | ||
| # | ||
| # The contents of this file are subject to the terms of the | ||
| # Common Development and Distribution License (the "License"). | ||
| # You may not use this file except in compliance with the License. | ||
| # | ||
| # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE | ||
| # or https://opensource.org/licenses/CDDL-1.0. | ||
| # See the License for the specific language governing permissions | ||
| # and limitations under the License. | ||
| # | ||
| # When distributing Covered Code, include this CDDL HEADER in each | ||
| # file and include the License file at usr/src/OPENSOLARIS.LICENSE. | ||
| # If applicable, add the following below this CDDL HEADER, with the | ||
| # fields enclosed by brackets "[]" replaced with your own identifying | ||
| # information: Portions Copyright [yyyy] [name of copyright owner] | ||
| # | ||
| # CDDL HEADER END | ||
| # | ||
|
|
||
| # | ||
| # Copyright (c) 2024 by Lawrence Livermore National Security, LLC. | ||
| # | ||
|
|
||
| . $STF_SUITE/include/libtest.shlib | ||
|
|
||
| # | ||
| # DESCRIPTION: | ||
| # Verify all cp --reflink modes work with modified file. | ||
| # | ||
| # STRATEGY: | ||
| # 1. Verify "cp --reflink=never|auto|always" behaves as expected. | ||
| # Two different modes of operation are tested. | ||
| # | ||
| # a. zfs_bclone_wait_dirty=0: FICLONE and FICLONERANGE fail with EINVAL | ||
| # when there are dirty blocks which cannot be immediately cloned. | ||
| # This is the default behavior. | ||
| # | ||
| # b. zfs_bclone_wait_dirty=1: FICLONE and FICLONERANGE wait for | ||
| # dirty blocks to be written to disk allowing the clone to succeed. | ||
| # The downside to this is it may be slow which depending on the | ||
| # situtation may defeat the point of making a clone. | ||
| # | ||
|
|
||
| verify_runnable "global" | ||
|
|
||
| if ! is_linux; then | ||
| log_unsupported "cp --reflink is a GNU coreutils option" | ||
| fi | ||
|
|
||
| function cleanup | ||
| { | ||
| datasetexists $TESTPOOL/cp-reflink && \ | ||
| destroy_dataset $$TESTPOOL/cp-reflink -f | ||
| log_must set_tunable32 BCLONE_WAIT_DIRTY 0 | ||
| } | ||
|
|
||
| function verify_copy | ||
| { | ||
| src_cksum=$(sha256digest $1) | ||
| dst_cksum=$(sha256digest $2) | ||
|
|
||
| if [[ "$src_cksum" != "$dst_cksum" ]]; then | ||
| log_must ls -l $CP_TESTDIR | ||
| log_fail "checksum mismatch ($src_cksum != $dst_cksum)" | ||
| fi | ||
| } | ||
|
|
||
| log_assert "Verify all cp --reflink modes work with modified file" | ||
|
|
||
| log_onexit cleanup | ||
|
|
||
| SRC_FILE=src.data | ||
| DST_FILE=dst.data | ||
| SRC_SIZE=$(($RANDOM % 2048)) | ||
|
|
||
| # A smaller recordsize is used merely to speed up the test. | ||
| RECORDSIZE=4096 | ||
|
|
||
| log_must zfs create -o recordsize=$RECORDSIZE $TESTPOOL/cp-reflink | ||
| CP_TESTDIR=$(get_prop mountpoint $TESTPOOL/cp-reflink) | ||
|
|
||
| log_must cd $CP_TESTDIR | ||
|
|
||
| # Never wait on dirty blocks (zfs_bclone_wait_dirty=0) | ||
| log_must set_tunable32 BCLONE_WAIT_DIRTY 0 | ||
|
|
||
| for mode in "never" "auto" "always"; do | ||
| log_note "Checking 'cp --reflink=$mode'" | ||
|
|
||
| # Create a new file and immediately copy it. | ||
| log_must dd if=/dev/urandom of=$SRC_FILE bs=$RECORDSIZE count=$SRC_SIZE | ||
|
|
||
| if [[ "$mode" == "always" ]]; then | ||
| log_mustnot cp --reflink=$mode $SRC_FILE $DST_FILE | ||
| log_must ls -l $CP_TESTDIR | ||
| else | ||
| log_must cp --reflink=$mode $SRC_FILE $DST_FILE | ||
| verify_copy $SRC_FILE $DST_FILE | ||
| fi | ||
| log_must rm -f $DST_FILE | ||
|
|
||
| # Append to an existing file and immediately copy it. | ||
| sync_pool $TESTPOOL | ||
| log_must dd if=/dev/urandom of=$SRC_FILE bs=$RECORDSIZE seek=$SRC_SIZE \ | ||
| count=1 conv=notrunc | ||
| if [[ "$mode" == "always" ]]; then | ||
| log_mustnot cp --reflink=$mode $SRC_FILE $DST_FILE | ||
| log_must ls -l $CP_TESTDIR | ||
| else | ||
| log_must cp --reflink=$mode $SRC_FILE $DST_FILE | ||
| verify_copy $SRC_FILE $DST_FILE | ||
| fi | ||
| log_must rm -f $DST_FILE | ||
|
|
||
| # Overwrite a random range of an existing file and immediately copy it. | ||
| sync_pool $TESTPOOL | ||
| log_must dd if=/dev/urandom of=$SRC_FILE bs=$((RECORDSIZE / 2)) \ | ||
| seek=$(($RANDOM % $SRC_SIZE)) count=$(($RANDOM % 16)) conv=notrunc | ||
| if [[ "$mode" == "always" ]]; then | ||
| log_mustnot cp --reflink=$mode $SRC_FILE $DST_FILE | ||
| log_must ls -l $CP_TESTDIR | ||
| else | ||
| log_must cp --reflink=$mode $SRC_FILE $DST_FILE | ||
| verify_copy $SRC_FILE $DST_FILE | ||
| fi | ||
| log_must rm -f $SRC_FILE $DST_FILE | ||
| done | ||
|
|
||
| # Wait on dirty blocks (zfs_bclone_wait_dirty=1) | ||
| log_must set_tunable32 BCLONE_WAIT_DIRTY 1 | ||
|
|
||
| for mode in "never" "auto" "always"; do | ||
| log_note "Checking 'cp --reflink=$mode'" | ||
|
|
||
| # Create a new file and immediately copy it. | ||
| log_must dd if=/dev/urandom of=$SRC_FILE bs=$RECORDSIZE count=$SRC_SIZE | ||
| log_must cp --reflink=$mode $SRC_FILE $DST_FILE | ||
| verify_copy $SRC_FILE $DST_FILE | ||
| log_must rm -f $DST_FILE | ||
|
|
||
| # Append to an existing file and immediately copy it. | ||
| log_must dd if=/dev/urandom of=$SRC_FILE bs=$RECORDSIZE seek=$SRC_SIZE \ | ||
| count=1 conv=notrunc | ||
| log_must cp --reflink=$mode $SRC_FILE $DST_FILE | ||
| verify_copy $SRC_FILE $DST_FILE | ||
| log_must rm -f $DST_FILE | ||
|
|
||
| # Overwrite a random range of an existing file and immediately copy it. | ||
| log_must dd if=/dev/urandom of=$SRC_FILE bs=$((RECORDSIZE / 2)) \ | ||
| seek=$(($RANDOM % $SRC_SIZE)) count=$(($RANDOM % 16)) conv=notrunc | ||
| log_must cp --reflink=$mode $SRC_FILE $DST_FILE | ||
| verify_copy $SRC_FILE $DST_FILE | ||
| log_must rm -f $SRC_FILE $DST_FILE | ||
| done | ||
|
|
||
| log_pass |