[2.1.9] Fails to compile with GCC-13 for AARCH64 #14624
Comments
|
btw master branch seems to build/compile ok |
behlendorf
added
the
Type: Architecture
|
This also affects 2.1.11. |
i can reproduce the issue. but the same bug exists on master branch. no change so far. still not working |
|
can confirm this issue on gcc-13 zfs-2.1.11 and clang-16. |
|
this fix here is working for me. is someone able to test it? `--- Kbuild.in (revision 52656) ifeq ($(CONFIG_ARM64),y) see also git commit in my repo BrainSlayer@aaf28a4 |
|
ping @kraj @ryao @Kokokokoka @matoro |
|
it still fails for me. see https://snips.sh/f/YE-061orqo |
|
@kraj are you sure that you reconfigured your tree? this patch needs that you run ./configure again before compiling. |
yes in yocto we automatically reconfigure packages i.e. run |
This is on my shortlist of things to do, although I don't have my aarch64 hardware setup for testing this right now (it is a RPi3 with an ancient Gentoo install that will take a long time to update). I will check this in an aarch64 cloud VM this week. |
|
@kraj autoreconf does not run ./configure. it just recreates the configure file and Makefile.in files |
i tested it using a cross compiler in my project. no device was involved (i'm working mainly on embedded systems) |
ofcourse, we run configure after regenerating it in do_configure task and then run resulting makefiles using make in do_compile, the link I have pasted is output of do_compile task alone. If you are interested in seeing do_configure logs, I can upload them too |
i have reviewed your pasted output. but the configure was missing. i just saw autoconf / aclocal |
|
btw. you can also just checkout my tree from my repo (not for productional use, it has a newer zstd version and has patches for musl). might be easier since it worked from scratch for me |
|
For me |
|
I am building master branch and this patch works for me |
the patch was made for master and for nothing else. btw. your log shows it failed. so what do you want to tell me here |
check master. this patch was made on top of the master branch and not a release version |
|
So, having just tested this, it breaks for me on 2.1.x and not git tip, because git tip already has something like the fix proposed above applied, courtesy of fe97504. So a cherrypick of that for 2.1.x (which would unfortunately not be clean, since the fragments need to go in different spots in 2.1, but still simple) would do it. A bespoke patch copying just that segment would too, for this one problem. Fixing that is straightforward, and I'll go open a backport PR shortly once I've tested this a little, but you still run afoul of #14555 on most kernels you might run with gcc 13. In 5.15, not so much, unless they backported it out of spite, but just to mention for anyone else who runs into this thread and wants to report that it still won't build because of GPL-only symbol |
- Clang 15 doesn't support `-fno-ipa-sra` anymore. Do a separate check for `-fno-ipa-sra` support by $KERNEL_CC. - Don't enable `-mgeneral-regs-only` for certain module files. Fix openzfs#13260 - Scope `GCC diagnostic ignored` statements to GCC only. Clang doesn't need them to compile the code. Porting notes: - Moved the stanzas removing -mgeneral-regs-only to Makefile.in since they wouldn't readily work in Kbuild.in and that did. Reviewed-by: Richard Yao <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#13260 Closes openzfs#14150 Closes openzfs#14624 Ported-by: Rich Ercolani <[email protected] Signed-off-by: Rich Ercolani <[email protected]>
- Clang 15 doesn't support `-fno-ipa-sra` anymore. Do a separate check for `-fno-ipa-sra` support by $KERNEL_CC. - Don't enable `-mgeneral-regs-only` for certain module files. Fix openzfs#13260 - Scope `GCC diagnostic ignored` statements to GCC only. Clang doesn't need them to compile the code. Porting notes: - Moved the stanzas removing -mgeneral-regs-only to Makefile.in since they wouldn't readily work in Kbuild.in and that did. Reviewed-by: Richard Yao <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#13260 Closes openzfs#14150 Closes openzfs#14624 Ported-by: Rich Ercolani <[email protected] Signed-off-by: Rich Ercolani <[email protected]>
backport a fix for gcc13 ref: openzfs/zfs#14624
- Clang 15 doesn't support `-fno-ipa-sra` anymore. Do a separate check for `-fno-ipa-sra` support by $KERNEL_CC. - Don't enable `-mgeneral-regs-only` for certain module files. Fix #13260 - Scope `GCC diagnostic ignored` statements to GCC only. Clang doesn't need them to compile the code. Porting notes: - Moved the stanzas removing -mgeneral-regs-only to Makefile.in since they wouldn't readily work in Kbuild.in and that did. Reviewed-by: Richard Yao <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes #13260 Closes #14150 Closes #14624 Ported-by: Rich Ercolani <[email protected] Signed-off-by: Rich Ercolani <[email protected]>
- Clang 15 doesn't support `-fno-ipa-sra` anymore. Do a separate check for `-fno-ipa-sra` support by $KERNEL_CC. - Don't enable `-mgeneral-regs-only` for certain module files. Fix openzfs#13260 - Scope `GCC diagnostic ignored` statements to GCC only. Clang doesn't need them to compile the code. Porting notes: - Moved the stanzas removing -mgeneral-regs-only to Makefile.in since they wouldn't readily work in Kbuild.in and that did. Reviewed-by: Richard Yao <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#13260 Closes openzfs#14150 Closes openzfs#14624 Ported-by: Rich Ercolani <[email protected] Signed-off-by: Rich Ercolani <[email protected]>
System information
Describe the problem you're observing
while exact sources build fine with gcc-12.
Compiling with gcc-13 ends up with following errors
Describe how to reproduce the problem
Use any distribution for aarch64 and use gcc-13 to compile zfs.
Include any warning/errors/backtraces from the system logs
error log
The text was updated successfully, but these errors were encountered: