Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 6.9 compat: bdev_open_by_path replaced by bdev_file_open_by_path #16027

Closed
satmandu opened this issue Mar 26, 2024 · 1 comment
Closed

Linux 6.9 compat: bdev_open_by_path replaced by bdev_file_open_by_path #16027

satmandu opened this issue Mar 26, 2024 · 1 comment
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@satmandu
Copy link
Contributor

As of torvalds/linux@910202f and Linux 6.9-rc1 struct bdev_handle *bdev_open_by_path has been replaced by struct file *bdev_file_open_by_path.

System information

Type Version/Name
Distribution Name Ubuntu
Distribution Version 23.10
Kernel Version 6.9-rc1
Architecture x86_64
OpenZFS Version 2.2.3

Describe the problem you're observing

This change breaks building OpenZFS 2.2.3 on Linux Kernel 6.9-rc1:

checking whether blkdev_get_by_path() exists and takes 3 args... no
checking whether blkdev_get_by_path() exists and takes 4 args... no
checking whether bdev_open_by_path() exists... configure: error:
        *** None of the expected "blkdev_get_by_path()" interfaces were detected.
        *** This may be because your kernel version is newer than what is
        *** supported, or you are using a patched custom kernel with
        *** incompatible modifications.
        ***
@satmandu satmandu added the Type: Defect Incorrect behavior (e.g. crash, hang) label Mar 26, 2024
@robn
Copy link
Member

robn commented Mar 26, 2024

Thanks for the report. I'm already working on the patch series.

robn added a commit to robn/zfs that referenced this issue Mar 27, 2024
@robn
Linux 6.9 compat: bdev handles are now struct file
58a326a 
bdev_open_by_path() is replaced by bdev_file_open_by_path(), which
returns a plain old struct file*. Release function is gone entirely; the
regular file release function fput() will take care of the bdev
specifics.

Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes openzfs#16027
robn added a commit to robn/zfs that referenced this issue Mar 27, 2024
@robn
Linux 6.9 compat: blk_alloc_disk() now takes two args
d3c7bb0 
There's an extra nullable arg for queue limits. Detect it, and set it to
NULL. Similar change for blk_mq_alloc_disk(), now three args, same
treatment.

Error return now has error encoded in the return, so detect with
IS_ERR() and explicitly NULL our own return.

Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes openzfs#16027
@robn robn mentioned this issue Mar 27, 2024
Closed
13 tasks
ptr1337 pushed a commit to CachyOS/zfs that referenced this issue Mar 31, 2024
@robn @ptr1337
Linux 6.9 compat: bdev handles are now struct file
a08c4e7 
bdev_open_by_path() is replaced by bdev_file_open_by_path(), which
returns a plain old struct file*. Release function is gone entirely; the
regular file release function fput() will take care of the bdev
specifics.

Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes openzfs#16027
ptr1337 pushed a commit to CachyOS/zfs that referenced this issue Mar 31, 2024
@robn @ptr1337
Linux 6.9 compat: blk_alloc_disk() now takes two args
228ff38 
There's an extra nullable arg for queue limits. Detect it, and set it to
NULL. Similar change for blk_mq_alloc_disk(), now three args, same
treatment.

Error return now has error encoded in the return, so detect with
IS_ERR() and explicitly NULL our own return.

Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes openzfs#16027
robn added a commit to robn/zfs that referenced this issue Apr 2, 2024
@robn
Linux 6.9 compat: bdev handles are now struct file
d691363 
bdev_open_by_path() is replaced by bdev_file_open_by_path(), which
returns a plain old struct file*. Release function is gone entirely; the
regular file release function fput() will take care of the bdev
specifics.

Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes openzfs#16027
robn added a commit to robn/zfs that referenced this issue Apr 2, 2024
@robn
Linux 6.9 compat: blk_alloc_disk() now takes two args
c5ad479 
There's an extra nullable arg for queue limits. Detect it, and set it to
NULL. Similar change for blk_mq_alloc_disk(), now three args, same
treatment.

Error return now has error encoded in the return, so detect with
IS_ERR() and explicitly NULL our own return.

Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes openzfs#16027
behlendorf pushed a commit that referenced this issue Apr 3, 2024
@robn @behlendorf
Linux 6.9 compat: blk_alloc_disk() now takes two args
6097a7b 
There's an extra nullable arg for queue limits. Detect it, and set it to
NULL. Similar change for blk_mq_alloc_disk(), now three args, same
treatment.

Error return now has error encoded in the return, so detect with
IS_ERR() and explicitly NULL our own return.

Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes #16027
Closes #16033
tonyhutter pushed a commit that referenced this issue May 2, 2024
@robn @tonyhutter
Linux 6.9 compat: bdev handles are now struct file
3bd7cd0 
bdev_open_by_path() is replaced by bdev_file_open_by_path(), which
returns a plain old struct file*. Release function is gone entirely; the
regular file release function fput() will take care of the bdev
specifics.

Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes #16027
Closes #16033
tonyhutter pushed a commit that referenced this issue May 2, 2024
@robn @tonyhutter
Linux 6.9 compat: blk_alloc_disk() now takes two args
9a7ef02 
There's an extra nullable arg for queue limits. Detect it, and set it to
NULL. Similar change for blk_mq_alloc_disk(), now three args, same
treatment.

Error return now has error encoded in the return, so detect with
IS_ERR() and explicitly NULL our own return.

Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes #16027
Closes #16033
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Sep 4, 2024
@robn @lundman
Linux 6.9 compat: bdev handles are now struct file
a6f7924 
bdev_open_by_path() is replaced by bdev_file_open_by_path(), which
returns a plain old struct file*. Release function is gone entirely; the
regular file release function fput() will take care of the bdev
specifics.

Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes openzfs#16027
Closes openzfs#16033
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Sep 4, 2024
@robn @lundman
Linux 6.9 compat: blk_alloc_disk() now takes two args
5c2b53c 
There's an extra nullable arg for queue limits. Detect it, and set it to
NULL. Similar change for blk_mq_alloc_disk(), now three args, same
treatment.

Error return now has error encoded in the return, so detect with
IS_ERR() and explicitly NULL our own return.

Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes openzfs#16027
Closes openzfs#16033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Linux 6.9 compatibility robn/zfs
2 participants
@robn @satmandu