Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make failed: the frame size of 1040 bytes is larger than 1024 bytes #40

Closed
domdorn opened this issue Jul 26, 2010 · 5 comments
Closed

Comments

@domdorn
Copy link

domdorn commented Jul 26, 2010

latest ubuntu.

/bin/bash ../../libtool  --tag=CC --silent  --mode=link gcc -Wall -Wstrict-prototypes -fno-strict-aliasing -Werror -D_GNU_SOURCE -D__EXTENSIONS__ -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DTEXT_DOMAIN=\"zfs-linux-user\" -g -O2   -o zpios zpios_main.o zpios_util.o  -luuid -luuid -lz -lz -lz 
make[3]: Leaving directory `/home/domdorn/tmp/zfs/zfs-0.4.9/cmd/zpios'
make[3]: Entering directory `/home/domdorn/tmp/zfs/zfs-0.4.9/cmd'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/home/domdorn/tmp/zfs/zfs-0.4.9/cmd'
make[2]: Leaving directory `/home/domdorn/tmp/zfs/zfs-0.4.9/cmd'
Making all in module
make[2]: Entering directory `/home/domdorn/tmp/zfs/zfs-0.4.9/module'
# Make the exported SPL symbols available to these modules.
cp /home/domdorn/tmp/zfs/behlendorf-spl-5c04498//module/Module.symvers .
make -C /usr/src/linux-headers-2.6.32-23-generic SUBDIRS=`pwd`  modules
make[3]: Entering directory `/usr/src/linux-headers-2.6.32-23-generic'
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/avl/avl.o
  LD [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/avl/zavl.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/nvpair/nvpair.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/nvpair/nvpair_alloc_spl.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/nvpair/nvpair_alloc_fixed.o
  LD [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/nvpair/znvpair.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/unicode/u8_textprep.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/unicode/uconv.o
  LD [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/unicode/zunicode.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zcommon/zfs_deleg.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zcommon/zfs_prop.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zcommon/zprop_common.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zcommon/zfs_namecheck.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zcommon/zfs_comutil.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zcommon/zpool_prop.o
  LD [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zcommon/zcommon.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/arc.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/bplist.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dbuf.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dmu.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dmu_object.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dmu_objset.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dmu_send.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dmu_traverse.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dmu_tx.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dmu_zfetch.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dnode.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dnode_sync.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dsl_dataset.o
  CC [M]  /home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dsl_deleg.o
cc1: warnings being treated as errors
/home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dsl_deleg.c: In function ‘dsl_deleg_get’:
/home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dsl_deleg.c:364: error: the frame size of 1040 bytes is larger than 1024 bytes
make[5]: *** [/home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs/dsl_deleg.o] Error 1
make[4]: *** [/home/domdorn/tmp/zfs/zfs-0.4.9/module/zfs] Error 2
make[3]: *** [_module_/home/domdorn/tmp/zfs/zfs-0.4.9/module] Error 2
make[3]: Leaving directory `/usr/src/linux-headers-2.6.32-23-generic'
make[2]: *** [modules] Error 2
make[2]: Leaving directory `/home/domdorn/tmp/zfs/zfs-0.4.9/module'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/domdorn/tmp/zfs/zfs-0.4.9'
make: *** [all] Error 2
root@domdorn-laptop:/home/domdorn/tmp/zfs/zfs-0.4.9# ls
aclocal.m4  ChangeLog  config.log     configure.ac  DISCLAIMER  lib   Makefile.am  META         README    zfs_config.h  zfs-modules.spec.in  zfs.spec.in
AUTHORS     cmd        config.status  COPYING       etc     libtool   Makefile.in  module           scripts   zfs_config.h.in   ZFS.RELEASE
autogen.sh  config     configure      COPYRIGHT     GIT     Makefile  man          OPENSOLARIS.LICENSE  stamp-h1  zfs-modules.spec  zfs.spec

root@domdorn-laptop:/home/domdorn/tmp/zfs/zfs-0.4.9# uname -a
Linux domdorn-laptop 2.6.32-23-generic #37-Ubuntu SMP Fri Jun 11 08:03:28 UTC 2010 x86_64 GNU/Linux
root@domdorn-laptop:/home/domdorn/tmp/zfs/zfs-0.4.9# 

using spl behlendorf-spl-5c04498

@behlendorf
Copy link
Contributor

This issue was fixed in the latest versions and will be fixed in the 0.5.0 which I hope to make soon. Can you pull the latest version from github and try again.

@domdorn
Copy link
Author

domdorn commented Jul 26, 2010

commit 7dfe24e94d3b7ecfb02ae8707404ec33937a6a7d
Merge: 12e83b7 641f300
Author: Brian Behlendorf 
Date:   Fri Jul 23 11:47:10 2010 -0700

gives me this error

/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:532: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:533: warning: ‘struct xuio’ declared inside parameter list
  CC [M]  /home/domdorn/tmp/zfs/zfs/module/zcommon/zpool_prop.o
In file included from /home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/spa.h:402,
                 from /home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/zio.h:30,
                 from /home/domdorn/tmp/zfs/zfs/module/zcommon/zpool_prop.c:26:
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:527: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:527: warning: its scope is only this definition or declaration, which is probably not what you want
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:528: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:530: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:531: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:532: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:533: warning: ‘struct xuio’ declared inside parameter list
  LD [M]  /home/domdorn/tmp/zfs/zfs/module/zcommon/zcommon.o
  CC [M]  /home/domdorn/tmp/zfs/zfs/module/zfs/arc.o
In file included from /home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/spa.h:402,
                 from /home/domdorn/tmp/zfs/zfs/module/zfs/arc.c:119:
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:527: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:527: warning: its scope is only this definition or declaration, which is probably not what you want
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:528: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:530: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:531: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:532: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/include/sys/dmu.h:533: warning: ‘struct xuio’ declared inside parameter list
/home/domdorn/tmp/zfs/zfs/module/zfs/arc.c: In function ‘arc_evict’:
/home/domdorn/tmp/zfs/zfs/module/zfs/arc.c:1654: error: implicit declaration of function ‘ddi_get_lbolt’
make[5]: *** [/home/domdorn/tmp/zfs/zfs/module/zfs/arc.o] Error 1
make[4]: *** [/home/domdorn/tmp/zfs/zfs/module/zfs] Error 2
make[3]: *** [_module_/home/domdorn/tmp/zfs/zfs/module] Error 2
make[3]: Leaving directory `/usr/src/linux-headers-2.6.32-23-generic'
make[2]: *** [modules] Error 2
make[2]: Leaving directory `/home/domdorn/tmp/zfs/zfs/module'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/domdorn/tmp/zfs/zfs'
make: *** [all] Error 2

@behlendorf
Copy link
Contributor

This failure looks like it was causing by building with an old version of the SPL. You will need to update both the spl and zfs and run a make distclean (or just rm and reclone the repos). Finally, make sure you don't have an old spl-devel package installed.

./configure && make distclean

@domdorn
Copy link
Author

domdorn commented Jul 26, 2010

works now.. wasn't sure how stable the master branch is.

test results:

root@domdorn-laptop:/home/domdorn/tmp/zfs/zfs# ./scripts/zconfig.sh 
test 1 - persistent zpool.cache: PASS
test 2 - scan disks for pools to import: PASS
test 3 - ZVOL sanity: PASS
test 4 - zpool import/export: PASS

root@domdorn-laptop:/home/domdorn/tmp/zfs/zfs# ./scripts/zpios-sanity.sh 
status    name        id    wr-data wr-ch   wr-bw   rd-data rd-ch   rd-bw
-------------------------------------------------------------------------------
PASS:     file-raid0   0    64m 64  8.85m   64m 64  3.13g
PASS:     file-raid10  0    64m 64  8.75m   64m 64  3.57g
PASS:     file-raidz   0    64m 64  5.12m   64m 64  2.78g
PASS:     file-raidz2  0    64m 64  2.60m   64m 64  1.47g
PASS:     lo-raid0     0    64m 64  29.73m  64m 64  3.13g
PASS:     lo-raid10    0    64m 64  5.37m   64m 64  1.93g
PASS:     lo-raidz     0    64m 64  5.44m   64m 64  1.47g
PASS:     lo-raidz2    0    64m 64  5.71m   64m 64  2.08g

Note: make install didn't install to /usr/libexec/zfs/zpios-sanity.sh, so I used the scripts in the ./scripts folder.

simply typing zfs gives the following error
root@domdorn-laptop:/home/domdorn/tmp/zfs/zfs# zfs
zfs: error while loading shared libraries: libspl.so.0: cannot open shared object file: No such file or directory

I had to run ldconfig as root to fix this. Maybe you can add this to an FAQ

thanks for this great driver/software.

@behlendorf
Copy link
Contributor

Glad to hear it worked for you this time. Yes, the latest master I try and keep as stable as I can... but no promises! As for the other install issues there some work under way to add support to build proper .deb packages for folks to use. With luck that will show up in the next few months.

@ehamberg ehamberg mentioned this issue Jun 16, 2012
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this issue Mar 1, 2015
Correct typos in the spl proc handler.
akatrevorjay added a commit to akatrevorjay/zfs that referenced this issue Dec 16, 2017
# This is the 1st commit message:
Merge branch 'master' of https://github.com/zfsonlinux/zfs

* 'master' of https://github.com/zfsonlinux/zfs:
  Enable QAT support in zfs-dkms RPM

# This is the commit message openzfs#2:

Import 0.6.5.7-0ubuntu3

# This is the commit message openzfs#3:

gbp changes

# This is the commit message openzfs#4:

Bump ver

# This is the commit message openzfs#5:

-j9 baby

# This is the commit message openzfs#6:

Up

# This is the commit message openzfs#7:

Yup

# This is the commit message openzfs#8:

Add new module

# This is the commit message openzfs#9:

Up

# This is the commit message openzfs#10:

Up

# This is the commit message openzfs#11:

Bump

# This is the commit message openzfs#12:

Grr

# This is the commit message openzfs#13:

Yay

# This is the commit message openzfs#14:

Yay

# This is the commit message openzfs#15:

Yay

# This is the commit message openzfs#16:

Yay

# This is the commit message openzfs#17:

Yay

# This is the commit message openzfs#18:

Yay

# This is the commit message openzfs#19:

yay

# This is the commit message openzfs#20:

yay

# This is the commit message openzfs#21:

yay

# This is the commit message openzfs#22:

Update ppa script

# This is the commit message openzfs#23:

Update gbp conf with br changes

# This is the commit message openzfs#24:

Update gbp conf with br changes

# This is the commit message openzfs#25:

Bump

# This is the commit message openzfs#26:

No pristine

# This is the commit message openzfs#27:

Bump

# This is the commit message openzfs#28:

Lol whoops

# This is the commit message openzfs#29:

Fix name

# This is the commit message openzfs#30:

Fix name

# This is the commit message openzfs#31:

rebase

# This is the commit message openzfs#32:

Bump

# This is the commit message openzfs#33:

Bump

# This is the commit message openzfs#34:

Bump

# This is the commit message openzfs#35:

Bump

# This is the commit message openzfs#36:

ntrim

# This is the commit message openzfs#37:

Bump

# This is the commit message openzfs#38:

9

# This is the commit message openzfs#39:

Bump

# This is the commit message openzfs#40:

Bump

# This is the commit message openzfs#41:

Bump

# This is the commit message openzfs#42:

Revert "9"

This reverts commit de488f1.

# This is the commit message openzfs#43:

Bump

# This is the commit message openzfs#44:

Account for zconfig.sh being removed

# This is the commit message openzfs#45:

Bump

# This is the commit message openzfs#46:

Add artful

# This is the commit message openzfs#47:

Add in zed.d and zpool.d scripts

# This is the commit message openzfs#48:

Bump

# This is the commit message openzfs#49:

Bump

# This is the commit message openzfs#50:

Bump

# This is the commit message openzfs#51:

Bump

# This is the commit message openzfs#52:

ugh

# This is the commit message openzfs#53:

fix zed upgrade

# This is the commit message openzfs#54:

Bump

# This is the commit message openzfs#55:

conf file zed.d

# This is the commit message #56:

Bump
anodos325 added a commit to anodos325/zfs that referenced this issue Mar 18, 2022
For Linux NFS kernel server ops, fsuid and fsgid in
cred are populated with ids that operation is
being performed as, but euid and egid remain 0.

In Linux when setresuid(2) and setresgid(2) are
called, the fsuid and fsgid are set to the euid
and egid respectively.

This PR changes ZFS ACL checks to evaluate
fsuid / fsgid rather than euid / egid to avoid
accidentally granting elevated permissions to
NFS clients.

Additionally, CAP_SYS_ADMIN is granted to nfsd
process, and so override for this capability in
access2 policy check is removed in favor of
simple check for fsid == 0. Checks for
CAP_DAC_OVERRIDE and other override capabilities
are kept as-is.

Signed-off-by: Andrew Walker <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants