Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata #4 doesn't mention non-destructive mitigation option #8682

Closed
JMoVS opened this issue Apr 29, 2019 · 0 comments · Fixed by #8683
Closed

Errata #4 doesn't mention non-destructive mitigation option #8682

JMoVS opened this issue Apr 29, 2019 · 0 comments · Fixed by #8683

Comments

@JMoVS
Copy link
Contributor

JMoVS commented Apr 29, 2019

System information

Type Version/Name
Distribution Name
Distribution Version
Linux Kernel
Architecture
ZFS Version 0.8.0 rc4
SPL Version

Describe the problem you're observing

@behlendorf Recently clarified how Errata #4 is actually processed in this comment:

#8625 (comment)

from there:

Deleting all the snapshots on the original source pool should be sufficient. The reason is that the fundamental fix for raw send issue was to associate an "IVset guid" with each snapshot. It acts as an identifier for the set of IVs used to encrypt a given snapshot and is now required during a raw receive. Since snapshot are immutable by design this "IVset guid" couldn't be associated with existing snapshots.

The errata will be reported in zpool status when either:

1. The `bookmarks_v2` feature has not been enabled, or

2. A snapshot is detected without the required "IVset guid"

If nothing is reported then all the snapshots in your encrypted pool do include the "IVset guid". I hope that helps clear things up.

If this fact was to be communicated more clearly, it could help people who have top-level encrypted datasets and who don't want to destroy their whole pools, as mentioned in this comment of mine:
#8308 (comment)

Describe how to reproduce the problem

Simply creating new snapshots and deleting old ones is sufficient to get rid of the warning.

JMoVS added a commit to JMoVS/zol that referenced this issue Apr 29, 2019
Errata openzfs#4 doesn’t mention a non-destructive way to clear it. This commits fixes openzfs#8682
JMoVS added a commit to JMoVS/zol that referenced this issue Apr 29, 2019
Errata openzfs#4 doesn’t mention a non-destructive way to clear it. This commits fixes openzfs#8682.

Signed-off-by: Justin Scholz <[email protected]>
JMoVS added a commit to JMoVS/zol that referenced this issue Apr 30, 2019
Errata openzfs#4 doesn’t mention a non-destructive way to clear it. This commits fixes openzfs#8682.

Signed-off-by: Justin Scholz <[email protected]>
JMoVS added a commit to JMoVS/zol that referenced this issue Apr 30, 2019
Errata openzfs#4 doesn’t mention a non-destructive way to clear it. This commits fixes openzfs#8682.

Signed-off-by: Justin Scholz <[email protected]>
JMoVS added a commit to JMoVS/zol that referenced this issue Apr 30, 2019
Errata openzfs#4 doesn’t mention a non-destructive way to clear it. This commits fixes openzfs#8682.

Signed-off-by: Justin Scholz <[email protected]>
JMoVS added a commit to JMoVS/zol that referenced this issue Apr 30, 2019
Errata openzfs#4 doesn’t mention a non-destructive way to clear it. This commits fixes openzfs#8682.

Signed-off-by: Justin Scholz <[email protected]>
JMoVS added a commit to JMoVS/zol that referenced this issue Apr 30, 2019
Errata openzfs#4 doesn’t mention a non-destructive way to clear it. This commits fixes openzfs#8682.

Signed-off-by: Justin Scholz <[email protected]>
JMoVS added a commit to JMoVS/zol that referenced this issue May 1, 2019
Errata openzfs#4 doesn’t mention a non-destructive way to clear it. This commits fixes openzfs#8682.

Signed-off-by: Justin Scholz <[email protected]>
behlendorf pushed a commit that referenced this issue May 2, 2019
Users of existing pools, especially pools with top-level encrypted 
datasets, could run into trouble trying to work around Errata #4. 
Clarify that removing encrypted snapshots and bookmarks is enough
to clear the errata.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Tom Caputi <[email protected]>
Signed-off-by: Justin Scholz <[email protected]>
Closes #8682 
Closes #8683
allanjude pushed a commit to allanjude/zfs that referenced this issue Jun 7, 2019
Users of existing pools, especially pools with top-level encrypted 
datasets, could run into trouble trying to work around Errata openzfs#4. 
Clarify that removing encrypted snapshots and bookmarks is enough
to clear the errata.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Tom Caputi <[email protected]>
Signed-off-by: Justin Scholz <[email protected]>
Closes openzfs#8682 
Closes openzfs#8683
allanjude pushed a commit to allanjude/zfs that referenced this issue Jun 15, 2019
Users of existing pools, especially pools with top-level encrypted 
datasets, could run into trouble trying to work around Errata openzfs#4. 
Clarify that removing encrypted snapshots and bookmarks is enough
to clear the errata.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Tom Caputi <[email protected]>
Signed-off-by: Justin Scholz <[email protected]>
Closes openzfs#8682 
Closes openzfs#8683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant