libshare: nfs: deduplication, don't SIGHUP everyone, retry flock() on EINTR, don't reopen temporary file #12067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
changed the title
nabijaczleweli
force-pushed
the
lack-a-too
branch
3 times, most recently
from
0afa4df
to
6c11619
Compare
nabijaczleweli
changed the title
nabijaczleweli
force-pushed
the
lack-a-too
branch
2 times, most recently
from
54adc9d
to
9781df6
Compare
nabijaczleweli
force-pushed
the
lack-a-too
branch
from
f138ab4
to
15090ee
Compare
nabijaczleweli
force-pushed
the
lack-a-too
branch
from
15090ee
to
54d8398
Compare
|
2-week bump? |
nabijaczleweli
force-pushed
the
lack-a-too
branch
from
54d8398
to
dde1608
Compare
|
Rebased (this has a logical conflict with #12191 w.r.t. visibility(hidden) but it's trivial to update either if one's merged first) |
nabijaczleweli
force-pushed
the
lack-a-too
branch
from
dde1608
to
07ec656
Compare
|
3-and-a-bit-week bump! |
nabijaczleweli
force-pushed
the
lack-a-too
branch
from
07ec656
to
566a9c0
Compare
nabijaczleweli
force-pushed
the
lack-a-too
branch
from
566a9c0
to
c491d52
Compare
|
Rebased cleanly |
|
Another week bump |
Description stolen from zfs-mount.8 Signed-off-by: Ahelenia Ziemiańska <[email protected]>
pidfile_open() sets *pidptr to -1 if the process currently holding the lock is between pidfile_open() and pidfile_write(), the subsequent kill(mountdpid) would potentially SIGHUP all non-system processes except init: just sleep for half a millisecond and try again in that case Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
The shares are publicly known anyway and can be interrogated by any user, so this is a debugging aid more than anything Signed-off-by: Ahelenia Ziemiańska <[email protected]>
behlendorf
pushed a commit
that referenced
this pull request
Dec 17, 2021
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #12067
behlendorf
pushed a commit
that referenced
this pull request
Dec 17, 2021
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #12067
behlendorf
pushed a commit
that referenced
this pull request
Dec 17, 2021
The shares are publicly known anyway and can be interrogated by any user, so this is a debugging aid more than anything. Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #12067
behlendorf
pushed a commit
that referenced
this pull request
Dec 17, 2021
This also works out to one syscall if the directory exists, but is one syscall shorter if it doesn't. Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #12067
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
Jan 19, 2022
pidfile_open() sets *pidptr to -1 if the process currently holding the lock is between pidfile_open() and pidfile_write(), the subsequent kill(mountdpid) would potentially SIGHUP all non-system processes except init: just sleep for half a millisecond and try again in that case Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
Feb 2, 2022
pidfile_open() sets *pidptr to -1 if the process currently holding the lock is between pidfile_open() and pidfile_write(), the subsequent kill(mountdpid) would potentially SIGHUP all non-system processes except init: just sleep for half a millisecond and try again in that case Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
tonyhutter
pushed a commit
that referenced
this pull request
Feb 3, 2022
pidfile_open() sets *pidptr to -1 if the process currently holding the lock is between pidfile_open() and pidfile_write(), the subsequent kill(mountdpid) would potentially SIGHUP all non-system processes except init: just sleep for half a millisecond and try again in that case Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #12067
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 10, 2022
Description stolen from zfs-mount.8 Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 14, 2022
Description stolen from zfs-mount.8 Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 16, 2022
Description stolen from zfs-mount.8 Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 17, 2022
Description stolen from zfs-mount.8 Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Description stolen from zfs-mount.8 Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
pidfile_open() sets *pidptr to -1 if the process currently holding the lock is between pidfile_open() and pidfile_write(), the subsequent kill(mountdpid) would potentially SIGHUP all non-system processes except init: just sleep for half a millisecond and try again in that case Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
The shares are publicly known anyway and can be interrogated by any user, so this is a debugging aid more than anything. Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
This also works out to one syscall if the directory exists, but is one syscall shorter if it doesn't. Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Description stolen from zfs-mount.8 Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
pidfile_open() sets *pidptr to -1 if the process currently holding the lock is between pidfile_open() and pidfile_write(), the subsequent kill(mountdpid) would potentially SIGHUP all non-system processes except init: just sleep for half a millisecond and try again in that case Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
The shares are publicly known anyway and can be interrogated by any user, so this is a debugging aid more than anything. Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
This also works out to one syscall if the directory exists, but is one syscall shorter if it doesn't. Reviewed-by: Don Brady <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Assorted bag of duplicate code and subtle deficiencies and/or improvements I found.
Description
See individual commit messages, all logically disparate.
How Has This Been Tested?
Ran zfs unshare -a and zfs share -a on Linux.
Types of changes
Checklist:
Signed-off-by.