Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: generate ABI files if changed #12379

Merged
merged 1 commit into from
Jul 20, 2021
Merged

CI: generate ABI files if changed #12379

merged 1 commit into from
Jul 20, 2021

Conversation

gmelikov
Copy link
Member

@gmelikov gmelikov commented Jul 15, 2021

So commit author can just download them as
artifacts and commit.

Example: https://github.com/gmelikov/zfs/actions/runs/1035256532

Signed-off-by: George Melikov [email protected]

Motivation and Context

Prepare everything for developer in CI.
Minor bonus - nearly identical build env = less unnecessary diff in files.

Description

Generate new ABI files on chekABI fail and present it as artifact, so developer can just download it and tar -xf abi_files.tar.

How Has This Been Tested?

Manual CI run, downloaded generated files and run make checkabi with them on fresh clone of repo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

So commit author can just download them as
artifacts and commit.

Signed-off-by: George Melikov <[email protected]>
@gmelikov gmelikov requested review from behlendorf and a user July 15, 2021 20:48
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a neat way of handling things! I do notice that the artifact is a .zip that contains a .tar, but at least on my mac the tar is extracted automatically anyway.

It would still be good to improve the portability of the *abi targets for use by downstream projects. I don't really want to have to push everything to github constantly. I do a lot of iterating locally and push to internally hosted git repos and CI systems before pushing to github. But at least this reduces the friction of contributions!

@jwk404 jwk404 merged commit bc93935 into openzfs:master Jul 20, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
So commit author can just download them as
artifacts and commit.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12379
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
So commit author can just download them as
artifacts and commit.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12379
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
So commit author can just download them as
artifacts and commit.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12379
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
So commit author can just download them as
artifacts and commit.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12379
behlendorf pushed a commit that referenced this pull request Aug 31, 2021
So commit author can just download them as
artifacts and commit.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes #12379
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
So commit author can just download them as
artifacts and commit.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12379
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
So commit author can just download them as
artifacts and commit.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants