Exclude zvol_misc_volmode for now #12733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It keeps failing, on changes which aren't related at all. So until someone runs down why, I'd like it to stop being the sole reason for CI failures. Signed-off-by: Rich Ercolani <[email protected]>
jwk404
approved these changes
Nov 8, 2021
behlendorf
approved these changes
Nov 8, 2021
gmelikov
approved these changes
Nov 8, 2021
pcd1193182
pushed a commit
to pcd1193182/zfs
that referenced
this pull request
Nov 12, 2021
It keeps failing, on changes which aren't related at all. So until someone runs down why, I'd like it to stop being the sole reason for CI failures. Reviewed-by: John Kennedy <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Rich Ercolani <[email protected]> Closes openzfs#12733
|
@rincebrain Is it possible that this may have been related to udev occasionally randomly failing to create the zvol dev node symlinks properly because of lock contention during zvol open (#12301)? Skimming the test file in question here suggests to me it could have been. If so, then the failures might not happen anymore, now that #12759 is merged. (If you already ruled out #12301 having anything to do with this, then disregard.) |
|
Certainly seems possible. I haven't revisited it since that landed, and I don't know that I'll doso in the near term, just because my time is rather spoken for for the next week at least. Feel free to revert this in a branch and test it yourself. :) |
|
This is pretty likely, I believe we should be able to revert this. |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 10, 2022
It keeps failing, on changes which aren't related at all. So until someone runs down why, I'd like it to stop being the sole reason for CI failures. Reviewed-by: John Kennedy <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Rich Ercolani <[email protected]> Closes openzfs#12733
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 14, 2022
It keeps failing, on changes which aren't related at all. So until someone runs down why, I'd like it to stop being the sole reason for CI failures. Reviewed-by: John Kennedy <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Rich Ercolani <[email protected]> Closes openzfs#12733
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 16, 2022
It keeps failing, on changes which aren't related at all. So until someone runs down why, I'd like it to stop being the sole reason for CI failures. Reviewed-by: John Kennedy <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Rich Ercolani <[email protected]> Closes openzfs#12733
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 17, 2022
It keeps failing, on changes which aren't related at all. So until someone runs down why, I'd like it to stop being the sole reason for CI failures. Reviewed-by: John Kennedy <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Rich Ercolani <[email protected]> Closes openzfs#12733
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
It keeps failing, on changes which aren't related at all.
So until someone runs down why, I'd like it to stop being the
sole reason for CI failures.
Description
It's an exclude.
How Has This Been Tested?
Not at all.
Types of changes
Checklist:
Signed-off-by.