Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfeature_common#zfs_mod_supported_feature(): FreeBSD supports edonr #12823

Merged
merged 2 commits into from
Dec 9, 2021
Merged

zfeature_common#zfs_mod_supported_feature(): FreeBSD supports edonr #12823

merged 2 commits into from
Dec 9, 2021

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented Dec 5, 2021 •
edited
Loading

Motivation and Context

This chases 269b5da (#12735), which touched the actual code but didn't fix the comment

Description

Comment fixed, name cast to void

How Has This Been Tested?

It, uh, builds, I guess?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli
zfeature_common#zfs_mod_supported_feature(): FreeBSD supports edonr
d07df90 
This chases 269b5da (openzfs#12735),
which touched the actual code but didn't fix the comment

Signed-off-by: Ahelenia Ziemiańska <[email protected]>
rincebrain
rincebrain approved these changes Dec 5, 2021
View reviewed changes
Copy link
Contributor

@rincebrain rincebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, someone pointed this out to me shortly after that PR landed, I made a branch fixing it and then just...forgot to open a PR. Whoops.

This incredibly risky and complicated change looks good to me.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 6, 2021
@behlendorf behlendorf merged commit 510885a into openzfs:master Dec 9, 2021
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
FreeBSD supports edonr follow up
6673561 
This chases 269b5da (openzfs#12735),
which touched the actual code but didn't fix the comment

Additionally, ignore the name.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rich Ercolani <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12823
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
FreeBSD supports edonr follow up
ae441f1 
This chases 269b5da (openzfs#12735),
which touched the actual code but didn't fix the comment

Additionally, ignore the name.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rich Ercolani <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@rincebrain rincebrain rincebrain approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabijaczleweli @behlendorf @rincebrain