Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.5-compat: intptr_t definition should be(?) signed but was unsigned #15058

Merged
merged 1 commit into from
Jul 14, 2023
Merged

6.5-compat: intptr_t definition should be(?) signed but was unsigned #15058

merged 1 commit into from
Jul 14, 2023

Conversation

ckane
Copy link
Contributor

@ckane ckane commented Jul 13, 2023

Motivation and Context

Elsewhere, the intptr_t is defined as a signed int type, but it was defined as unsigned here. This was found to be breaking the build for me against 5.9rc1.

Description

Change the definition of intptr_t from unsigned long to long

How Has This Been Tested?

Tested build against 6.4.2, and tested against 6.5rc1 (however, 6.5rc1 has other breaking changes too).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ckane
intptr_t definition is canonically signed
4ecdf5a 
Make the version here match that elsewhere in the kernel and system
headers.

Signed-off-by: Coleman Kane <[email protected]>
@ckane ckane changed the title intptr_t definition should be(?) signed but was unsigned 6.5-compat: intptr_t definition should be(?) signed but was unsigned Jul 13, 2023
amotin
amotin approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. intptr_t should be signed, unlike uintptr_t. I am just curios, why intptr_t is declared here, while uintptr_t is not. How does it work?

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries labels Jul 14, 2023
@behlendorf behlendorf merged commit 3a3e0d6 into openzfs:master Jul 14, 2023
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jul 21, 2023
@ckane @behlendorf
Linux 6.5 compat: intptr_t definition is canonically signed
b6ed318 
Make the version here match that elsewhere in the kernel and system
headers.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Coleman Kane <[email protected]>
Closes openzfs#15058
Signed-off-by: Brian Behlendorf <[email protected]>
behlendorf pushed a commit that referenced this pull request Jul 21, 2023
@ckane @behlendorf
Linux 6.5 compat: intptr_t definition is canonically signed
931dc70 
Make the version here match that elsewhere in the kernel and system
headers.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Coleman Kane <[email protected]>
Closes #15058
Signed-off-by: Brian Behlendorf <[email protected]>
tonyhutter pushed a commit that referenced this pull request Sep 27, 2023
@ckane @tonyhutter
intptr_t definition is canonically signed
92fc218 
Make the version here match that elsewhere in the kernel and system
headers.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Coleman Kane <[email protected]>
Closes #15058
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@ckane @lundman
intptr_t definition is canonically signed
cc98dbe 
Make the version here match that elsewhere in the kernel and system
headers.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Coleman Kane <[email protected]>
Closes openzfs#15058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckane @behlendorf @amotin