Remove implication that child disks aren't vdevs in zpoolconcepts(7)
#15247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, so unlike the previous one (checkstyle), the current failure (20.04 zloop) seems unlikely my doing. |
behlendorf
approved these changes
Sep 8, 2023
Signed-off-by: Laura Hild <[email protected]>
behlendorf
approved these changes
Sep 11, 2023
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Sep 19, 2023
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Laura Hild <[email protected]> Closes openzfs#15247
behlendorf
pushed a commit
that referenced
this pull request
Sep 19, 2023
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Laura Hild <[email protected]> Closes #15247
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Laura Hild <[email protected]> Closes openzfs#15247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
A poster on a ZFS forum pointed out to me that zpoolconcepts(7) currently says that "virtual devices cannot be nested," which was inconsistent with my assertion that (child)
disks are also "vdevs."Alternatively, if I'm wrong about that, please give me some clarification so I can think about how to clarify that instead!
Description
I rephrase the paragraph to be clearer that it is only certain types of vdevs that cannot be nested, so as not to imply that child
files anddisks are not considered "vdevs."How Has This Been Tested?
man ./zpoolconcepts.7
mandoc -T lint zpoolconcepts.7
Types of changes
Checklist:
Signed-off-by.