Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly pad struct tx_cpu to cache line #15402

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Properly pad struct tx_cpu to cache line #15402

merged 1 commit into from
Oct 20, 2023

Conversation

amotin
Copy link
Member

@amotin amotin commented Oct 14, 2023

We already use ____cacheline_aligned in many places, so add one more instead of seems arbitrary char tc_pad[8].

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Properly pad struct tx_cpu to cache line
2c99643 
We already use ____cacheline_aligned in many places, so add one more
instead of seems arbitrary char tc_pad[8].

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Oct 14, 2023
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 20, 2023
@behlendorf behlendorf merged commit b29e98f into openzfs:master Oct 20, 2023
25 of 26 checks passed
@amotin amotin deleted the tc_pad branch October 20, 2023 22:13
amotin added a commit to amotin/zfs that referenced this pull request Nov 6, 2023
@amotin
Properly pad struct tx_cpu to cache line
7f1e00b 
We already use ____cacheline_aligned in many places, so add one more
instead of seems arbitrary char tc_pad[8].

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#15402
ixhamza pushed a commit to truenas/zfs that referenced this pull request Nov 20, 2023
@amotin @tonyhutter
Properly pad struct tx_cpu to cache line
eaa62d9 
We already use ____cacheline_aligned in many places, so add one more
instead of seems arbitrary char tc_pad[8].

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#15402
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@amotin @lundman
Properly pad struct tx_cpu to cache line
458c66f 
We already use ____cacheline_aligned in many places, so add one more
instead of seems arbitrary char tc_pad[8].

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#15402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amotin @behlendorf