ZTS: fix flakiness in cp_files_002_pos #16029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
cp_files_002_pos
fails 26 out of 500 timesThe
$RANDOM
count argument todd
can be zero sometimes leading to spurious errors.Description
Example failing log:
Overwriting with
dd ... count=0
does not exercise any code, so thencp --reflink=always
spuriously succeeds because it does not test anything.The fix is to adjust sizes so that
$RANDOM
yielding zero does not affect the test outcome.How Has This Been Tested?
Ran cp_files_002_pos 500 times with zero failures.
Types of changes
Checklist:
Signed-off-by
.