Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more taskq parameters writable #16118

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

amotin
Copy link
Member

@amotin amotin commented Apr 21, 2024

There is no reason for these module parameters to be read-only. Being modified they just apply on next pool import/creation, that is useful for testing different values.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Apr 21, 2024
@rincebrain
Copy link
Contributor

rincebrain commented Apr 21, 2024

It's probably useful to call out the fact that those only change for pools imported after you modify them, lest people start asking why their changes didn't work. (That is, in the man page for these, since before it wasn't possible to observe this fact.)

@amotin
Copy link
Member Author

amotin commented Apr 21, 2024

The more we write, the less people read...

@rincebrain
Copy link
Contributor

I mean, yes, but most tunables we call out if they don't apply "normally", like the scrub tunables not applying to existing scrubs.

@behlendorf
Copy link
Contributor

Yes, if we're going to make these runtime tunable let's document when those updated values get applied. I'd think we'd also want to make the same change for zio_taskq_read and zio_taskq_write. I see zio_taskq_wr_iss_ncpus can already be modified and that's not documented either.

It would take a bit more work but it would be really nice for performance testing if the taskqs could be recreated, or modified, immediately.

There is no reason for these module parameters to be read-only.
Being modified they just apply on next pool import/creation, that
is useful for testing different values.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
@amotin
Copy link
Member Author

amotin commented Apr 24, 2024

@rincebrain @behlendorf Updated.

@amotin amotin changed the title Make zio_taskq_batch_pct/_tpq writable Make more taskq parameters writable Apr 24, 2024
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 24, 2024
@behlendorf behlendorf merged commit 67d1399 into openzfs:master Apr 24, 2024
24 of 26 checks passed
amotin added a commit to amotin/zfs that referenced this pull request May 23, 2024
There is no reason for these module parameters to be read-only.
Being modified they just apply on next pool import/creation, that
is useful for testing different values.

Reviewed-by: Rich Ercolani <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#16118
ixhamza pushed a commit to truenas/zfs that referenced this pull request May 23, 2024
There is no reason for these module parameters to be read-only.
Being modified they just apply on next pool import/creation, that
is useful for testing different values.

Reviewed-by: Rich Ercolani <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#16118
ixhamza pushed a commit to truenas/zfs that referenced this pull request May 23, 2024
There is no reason for these module parameters to be read-only.
Being modified they just apply on next pool import/creation, that
is useful for testing different values.

Reviewed-by: Rich Ercolani <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#16118
behlendorf pushed a commit that referenced this pull request May 29, 2024
There is no reason for these module parameters to be read-only.
Being modified they just apply on next pool import/creation, that
is useful for testing different values.

Reviewed-by: Rich Ercolani <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes #16118
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
There is no reason for these module parameters to be read-only.
Being modified they just apply on next pool import/creation, that
is useful for testing different values.

Reviewed-by: Rich Ercolani <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#16118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants