Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy ARC buffer in case of fill error #16216

Merged
merged 1 commit into from
May 25, 2024
Merged

Destroy ARC buffer in case of fill error #16216

merged 1 commit into from
May 25, 2024

Conversation

amotin
Copy link
Member

@amotin amotin commented May 22, 2024

In case of error dmu_buf_fill_done() returns the buffer back into DB_UNCACHED state. Since during transition from DB_UNCACHED into DB_FILL state dbuf_noread() allocates an ARC buffer, we must free it here, otherwise it will be leaked.

Fixes: #15665
Closes: #15802

How Has This Been Tested?

See the test reproduction in #15802 (comment) .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Destroy ARC buffer in case of fill error
a1bf16c 
In case of error dmu_buf_fill_done() returns the buffer back into
DB_UNCACHED state.  Since during transition from DB_UNCACHED into
DB_FILL state dbuf_noread() allocates an ARC buffer, we must free
it here, otherwise it will be leaked.

Fixes:	openzfs#15665
Closes:	openzfs#15802
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
@amotin amotin added the Status: Code Review Needed Ready for review and testing label May 22, 2024
@lundman lundman mentioned this pull request May 22, 2024
Open
@behlendorf behlendorf merged commit 02c5aa9 into openzfs:master May 25, 2024
23 checks passed
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 25, 2024
@amotin amotin deleted the fill_done_err_destroy branch May 25, 2024 02:28
robn pushed a commit to robn/zfs that referenced this pull request Jul 18, 2024
@amotin @tonyhutter
Destroy ARC buffer in case of fill error
ba3c769 
In case of error dmu_buf_fill_done() returns the buffer back into
DB_UNCACHED state.  Since during transition from DB_UNCACHED into
DB_FILL state dbuf_noread() allocates an ARC buffer, we must free
it here, otherwise it will be leaked.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Jorgen Lundman <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#15665
Closes openzfs#15802
Closes openzfs#16216
bsdjhb pushed a commit to CTSRD-CHERI/zfs that referenced this pull request Aug 1, 2024
@amotin @bsdjhb
Destroy ARC buffer in case of fill error
dc5906b 
In case of error dmu_buf_fill_done() returns the buffer back into
DB_UNCACHED state.  Since during transition from DB_UNCACHED into
DB_FILL state dbuf_noread() allocates an ARC buffer, we must free
it here, otherwise it will be leaked.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Jorgen Lundman <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#15665
Closes openzfs#15802
Closes openzfs#16216
(cherry picked from commit 02c5aa9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundman lundman lundman approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: VERIFY3(rc->rc_count == number) failed (FreeBSD 15-CURRENT, ZFS 2.1.14)
3 participants
@amotin @behlendorf @lundman