Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs.4: Document the actual default for zfs_txg_history #16305

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

0mp
Copy link
Contributor

@0mp 0mp commented Jun 27, 2024

Motivation and Context

zfs.4 documents the default of zfs_txg_history to be 0. This is incorrect. The default is 100.

Description

$ grep zfs_txg_history module/zfs/spa_stats.c
static uint_t zfs_txg_history = 100;
        if (zfs_txg_history == 0 && shl->size == 0)
        spa_txg_history_truncate(shl, zfs_txg_history);
        if (zfs_txg_history == 0)
        if (zfs_txg_history == 0)
        if (zfs_txg_history == 0)
        if (zfs_txg_history == 0) {

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.

How Has This Been Tested?

The manual renders fine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Signed-off-by: Mateusz Piotrowski <[email protected]>
@tonyhutter
Copy link
Contributor

You are correct, thanks for the fix:

$ cat /sys/module/zfs/parameters/zfs_txg_history 
100

@tonyhutter tonyhutter merged commit fd51786 into openzfs:master Jun 28, 2024
21 of 25 checks passed
calccrypto pushed a commit to hpc/zfs that referenced this pull request Jul 3, 2024
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.

Signed-off-by: Mateusz Piotrowski <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.

Signed-off-by: Mateusz Piotrowski <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants