Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libspl/backtrace: dump registers in libunwind backtraces #16653

Closed
wants to merge 4 commits into from
Closed

libspl/backtrace: dump registers in libunwind backtraces #16653

wants to merge 4 commits into from

Commits on Oct 18, 2024

  1. libspl/backtrace: dump registers in libunwind backtraces 

    More useful stuff, especially when trying to follow a disassembly.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <[email protected]>
    @robn
    robn committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    699f0a3 View commit details
    Browse the repository at this point in the history

  2. libspl/backtrace: helper macros for output 

    My eyes are going blurry looking at all those write calls. This is much
nicer.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <[email protected]>
    @robn
    robn committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    128dbc2 View commit details
    Browse the repository at this point in the history

  3. libspl/backtrace: rename and document hex conversion function 

    Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <[email protected]>
    @robn
    robn committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    83f7f19 View commit details
    Browse the repository at this point in the history

  4. libspl/backtrace: comment and harden libunwind backtracer 

    This is the sort of code that we get right once and never look at again.
Anyone reading this code is already likely in the middle of a debugging
nightmare, and then they have a wall of manual string construction and
an unfamiliar and idiosyncratic library to deal with. So, comment the
whole thing to try to make it clear what's going on.

In pursuit of the above, I've added return checks to some of the
libunwind calls, fixed the frame loop to not skip the "top" frame
(however unseful it may be), and fix a couple of calls to
spl_bt_u64_to_hex_str() which requested 18 digits instead of 16.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <[email protected]>
    @robn
    robn committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bbec61d View commit details
    Browse the repository at this point in the history