Instead of hardcoding paths, look for them in the most obvious places #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FransUrbo sorry I lost track of this. When you get a moment could you rebase it on master so it'll run through the buildbot. Since many of the test cases depend on this common functionality we'll learn pretty quickly if this is safe to merge. |
|
Yeah, I was afraid of that. @FransUrbo let's not rock the boat here so to speak. This issue only impacted Arch Linux and arguably they can handle that downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #460
I know this is somewhat ugly, but I think it's better than hardcoding paths (which, as I've said elsewhere, I really, really hate! :).
To support the old behavior (setting the variable in the shell before calling), I first check to make sure the variable is empty, THEN check for it's existance...
The issue mentioned only talks about lsmod, but I figure since I do this, I could just as well do it for all the commands (including the udev{trigger,settle})...