Fix iterByTitle.
#518
Fix iterByTitle.
#518
Conversation
mgautierfr
force-pushed
the
iter_by_title
branch
from
c64de84
to
4a0488c
Compare
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
- Coverage 76.36% 76.35% -0.01%
==========================================
Files 89 89
Lines 3655 3659 +4
Branches 1640 1661 +21
==========================================
+ Hits 2791 2794 +3
- Misses 863 864 +1
Partials 1 1
Continue to review full report at Codecov.
|
src/fileimpl.h
Outdated
| @@ -89,6 +90,7 @@ namespace zim | |||
| const Fileheader& getFileheader() const { return header; } | |||
| zsize_t getFilesize() const; | |||
| bool hasNewNamespaceScheme() const { return m_newNamespaceScheme; } | |||
| bool hasFullTitleIndex() const { return m_hasFullTitleIndex; } | |||
There was a problem hiding this comment.
Doesn't it make sense to signal the presence of a front article index instead? As far as I understand the full title index should be always present in a ZIM archive, but it is "overriden" by the front article index if the latter is available.
There was a problem hiding this comment.
Yes, as it is a internal method I haven't think a lot on the api (better to discuss in #514).
But your remark is right. And is is more coherent with hasNewNamespaceScheme which return true if we have something "new".
|
@mgautierfr @veloman-yunkan I don’t understand what is the status of this PR |
|
I had to change the PR following the @veloman-yunkan remarks. This is done now. |
If we have a specific title index, we must iterate on it. We must not iterate on a (wrong) subset of the entries. Related to #514
Rename hasFullTitleIndex to hasFrontArticleIndex.
mgautierfr
force-pushed
the
iter_by_title
branch
from
aae2ed5
to
685888d
Compare
|
@mgautierfr Is this PR enough tested, codecov complains it does not meet our standarts. |
|
We are missing a test zim file with the new format. |
I don't object, though I think that changes must be tested as soon as they are introduced. |
I agree, should be automated tested before merging this PR. |
|
superseded by #535 |
If we have a specific title index, we must iterate on it.
We must not iterate on a (wrong) subset of the entries.
Related to #514
(This doesn't try to fix #514)