Remove test data from repository and use data from zim-testing-suite. #538
Conversation
mgautierfr
force-pushed
the
no_test_data2
branch
from
cf9d504
to
6c6058d
Compare
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
=======================================
Coverage 79.30% 79.30%
=======================================
Files 91 91
Lines 3744 3744
Branches 1701 1701
=======================================
Hits 2969 2969
Misses 774 774
Partials 1 1 Continue to review full report at Codecov.
|
mgautierfr
force-pushed
the
no_test_data2
branch
from
6c6058d
to
7f058fe
Compare
Done. |
|
@legoktm Is it ok for you ? |
As you had suggested in #531 (comment), can we have an environment variable that causes it to skip these tests? That can be set in debian/rules and then fixing the packaging no longer blocks you.
Yes, building the Debian package shouldn't require any Internet dependencies. We (I really) should add the packaging configuration to zim-testing-suite so it's in our PPA and libzim can depend on it like a normal apt dependency. I can start working on that over the weekend. |
|
@legoktm Any news about a fix of the deb package CI? |
The script can be run directly but can (and will) be also called by meson.
The target is not run by default. It allow user to download the data itself if he wish. To download the data using meson, one must run `ninja download_test_data` once configured. The path to the data dir must be passed to meson using the `test_data_dir` option (`-Dtest_data_dir=/foo/test_data`). If the option is not passed, default to a subdirectory inside the build directory.
Downloading external files to run tests may not be optimal depending of the situation. This allow to be able to still compile/test libzim without downloading the test files.
mgautierfr
force-pushed
the
no_test_data2
branch
from
14476d9
to
3a665cc
Compare
|
@legoktm last commit add a option to deactivate tests using external test data. We need to pass the option |
Skips zim-testing-data tests until we package that.
I had to look it up myself :) pushed the fix, which also makes it obvious how to add more config flags in the future. |
|
There is still two codefactor issues. |
I consider them as two false positives. |
This PR remove the data from the repository and download the data from zim-testing-suite.
It should be considered as a preparatory work of #535.
It replace #531 answering comments addressed:
@legoktm On packaging side, you can use the provided script to download the data or make the archive a second source and just configure meson correctly.
For now, this PR works only if
test_data_diroption is not used (tests look intest/datadirectory in build dir).This PR must be considered with #535 where test are using data pointed by the env var.
The two PR will be merge together to avoid to add the new zim files to the repository. But I've created a separated PR to concentrate on the download process as we already agreed on the new tests themselves.