Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter metadata #539

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Counter metadata #539

merged 2 commits into from
Apr 21, 2021

Conversation

mgautierfr
Copy link
Collaborator

Fix #532

@mgautierfr
Add a isCompressible method to the direntHandler.
db6b6b2 
Content created by the direntHandler may be compressible.
We must not assume it is uncompressible and let the the handler set
if we compress the content or not.
@mgautierfr
Create automatically M/Counter metadata.
cb56d5f 
Add a `counterHandler` to count number of mimetype in C namespace.
@mgautierfr mgautierfr changed the base branch from master to better_tests_data April 20, 2021 17:10
@codecov
Copy link

codecov bot commented Apr 20, 2021 •
edited
Loading

Codecov Report

Merging #539 (cb56d5f) into better_tests_data (a6fee67) will increase coverage by 0.08%.
The diff coverage is 90.32%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           better_tests_data     #539      +/-   ##
=====================================================
+ Coverage              79.80%   79.88%   +0.08%     
=====================================================
  Files                     89       91       +2     
  Lines                   3718     3748      +30     
  Branches                1649     1661      +12     
=====================================================
+ Hits                    2967     2994      +27     
- Misses                   750      753       +3     
  Partials                   1        1
Impacted Files Coverage Δ
src/writer/handler.h 100.00% <ø> (ø)
src/writer/counterHandler.cpp 87.50% <87.50%> (ø)
src/writer/counterHandler.h 100.00% <100.00%> (ø)
src/writer/creator.cpp 83.49% <100.00%> (+0.05%) ⬆️
src/writer/titleListingHandler.h 100.00% <100.00%> (ø)
src/writer/xapianHandler.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6fee67...cb56d5f. Read the comment docs.

veloman-yunkan
veloman-yunkan approved these changes Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit 91eab3b into better_tests_data Apr 21, 2021
@kelson42 kelson42 deleted the counter_metadata branch April 21, 2021 05:01
@mgautierfr
Copy link
Collaborator Author

I've merge the branch into better_tests_data branch (PR #535).
This is somehow by fault as I've based my work on it "by default" even if this is not needed for this PR.
I will rebase this branch on master and merge it correctly.

@mgautierfr mgautierfr restored the counter_metadata branch April 21, 2021 09:02
@mgautierfr mgautierfr mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veloman-yunkan veloman-yunkan veloman-yunkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Counter metadata
3 participants
@mgautierfr @veloman-yunkan @kelson42