Reintroduce Optimization of Entry::getItem() #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a client of libzim the only way to create an `Item` object is through `Entry::getItem()` or `Entry::getRedirect()` (the latter relying on the former to deliver the final result). Before this change, `Entry::getItem()` performed (via the `Item` constructor) an extra call to `FileImpl::getDirent(entry_index_t)`. Now the result of that operation that is readily available in the source `Entry` object is reused.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
- Coverage 57.57% 57.57% -0.01%
==========================================
Files 98 99 +1
Lines 4545 4542 -3
Branches 1911 1909 -2
==========================================
- Hits 2617 2615 -2
Misses 668 668
+ Partials 1260 1259 -1
☔ View full report in Codecov by Sentry. |
mgautierfr
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #769
For a client of libzim the only way to create an
Itemobject is throughEntry::getItem()orEntry::getRedirect()(the latter relying on the former to deliver the final result).Before this change,
Entry::getItem()performed (via theItemconstructor) an extra call toFileImpl::getDirent(entry_index_t). Now the result of that operation that is readily available in the sourceEntryobject is reused.