Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAP_POPULATE is Linux-specific and not declared on other platforms #929

Merged
merged 1 commit into from
Aug 30, 2024
Merged

MAP_POPULATE is Linux-specific and not declared on other platforms #929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/file_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ class MMapException : std::exception {};
char*
mmapReadOnly(int fd, offset_type offset, size_type size)
{
#if defined(__APPLE__) || defined(__OpenBSD__) || defined(__HAIKU__)
const auto MAP_FLAGS = MAP_PRIVATE;
#if defined(__linux__)
const auto MAP_FLAGS = MAP_PRIVATE|MAP_POPULATE;
#elif defined(__FreeBSD__)
const auto MAP_FLAGS = MAP_PRIVATE|MAP_PREFAULT_READ;
#else
const auto MAP_FLAGS = MAP_PRIVATE|MAP_POPULATE;
const auto MAP_FLAGS = MAP_PRIVATE;
#endif

const auto p = (char*)mmap(NULL, size, PROT_READ, MAP_FLAGS, fd, offset);
Expand Down
Loading