Treat hidden DOM elements before treating media files. #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavel-karatsiuba please add a test. addind to one of the e2e test, an article with such a scenario should be enough |
Codecov ReportBase: 69.53% // Head: 69.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1780 +/- ##
==========================================
+ Coverage 69.53% 69.64% +0.11%
==========================================
Files 23 23
Lines 2583 2583
Branches 590 590
==========================================
+ Hits 1796 1799 +3
Misses 674 674
+ Partials 113 110 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@pavel-karatsiuba Does it fix #1765 as well? |
Yes, #1765 is also fixed. I will add a test with the article from #1765. |
kelson42
force-pushed
the
treatment-sequence
branch
from
96d9614
to
08d56d8
Compare
kelson42
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before downloading media files need to remove hidden elements from HTML
fixes #849
fixes #1765