Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print error and stop the script if mandatory Metadata key is not set #1806

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Print error and stop the script if mandatory Metadata key is not set #1806

merged 7 commits into from
Apr 5, 2023

Commits on Mar 27, 2023

  1. Added value of "verbose" parameter into the log if it is invalid.

    @pavel-karatsiuba
    pavel-karatsiuba committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    ba4c709 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Merge pull request #1820 from openzim/improving-logging-with-wrong-ve… 

    …rbose-option

Added value of "verbose" parameter into the log if it is invalid.
    @kelson42
    kelson42 authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4298129 View commit details
    Browse the repository at this point in the history

  2. throw exception if mandatory Metadata key is not set

    @pavel-karatsiuba @kelson42
    pavel-karatsiuba authored and kelson42 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    5159a01 View commit details
    Browse the repository at this point in the history

  3. Don't throw exception if mandatory Metadata key is empty but print er… 

    …ror and stop script.
    @pavel-karatsiuba @kelson42
    pavel-karatsiuba authored and kelson42 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    6456a2a View commit details
    Browse the repository at this point in the history

  4. sanitize metadata mandatory fields

    @pavel-karatsiuba @kelson42
    pavel-karatsiuba authored and kelson42 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c350539 View commit details
    Browse the repository at this point in the history

  5. Fixed tests to fit sanitizing rules for Description. 

    lint fixes
    @pavel-karatsiuba @kelson42
    pavel-karatsiuba authored and kelson42 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7ccbefc View commit details
    Browse the repository at this point in the history

  6. Added all metadata keys into rules to validate.

    @pavel-karatsiuba @kelson42
    pavel-karatsiuba authored and kelson42 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f070b80 View commit details
    Browse the repository at this point in the history