-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add urls support to collections. #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Can you please:
- Add a check for clashing filenames? If we request (directly or indirectly) several files to be stored at the same path, the first one will get the spot and the rest will silently point to it. We should raise on such conflict.
- Update the README to mention the new format(s)
- Update the CHANGELOG to add the feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great but duplicate name is not working
[
{
"title": "Fledge PDF",
"description": "Someting in his ZIP",
"authors": "n/a",
"files": ["test.pdf"]
},
{
"title": "Tarifs I SAGO",
"description": "Tarifs électricité Mali",
"authors": "EDM",
"files": [
{
"archive_member": "test.pdf",
"url": "https://isago.rskg.org/static/tarifs-isago.pdf",
"filename": "test.pdf"
}
]
}
]
This doesn't raise while it should.
The problem is you are looking for duplicates in path
instead of filename
. path
is used only to retrieve member_name (maybe it should be renamed) and we don't care about using it multiple times.
I see. you are right, |
You may also want to only display duplicate ones (using a set) ; otherwise
You should also look into refactoring a bit test_collection to please Codefactor |
I just changed the |
Fix #59