-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to Archiveless collection #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised to discover that --archive
was already a non-required argument! 😀
Anyway I think your approach is not right. Most of check_archiveless_collection
is duplicated code from other parts.
It would be best to adapt or rewrite test_files
to support both and reduce code duplication.
Also, please add an entry in the CHANGELOG
Ah I realize the PR is in Draft ; Sorry 😀 |
Yeah, that's my plan.
lol, it's ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny fix remaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fix: #60.