Fail scrapper when there are too many errors while retrieving xblocks #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
fail_on_too_many_errors
branch
from
a29aa9d
to
142b30c
Compare
rgaudin
requested changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Fix #160
Changes
Implementation details
there is now a global watcher for all xblocks, with
total_count: the total number of xblocks to retrievedl_count: the total number of xblocks download attempt so farsuccess_count: the total number of xblocks successful download so farfailed_xblocks: details about failed xblocksthere are two parameters to control scrapper stop:
watcher_min_ratio: the minimum ratio of successful downloads (compared to the number of download attempts)watcher_min_dl_count: the minimum number of xblocks to have attempted to download before stopping the scraper (because otherwise the ratio might be wrong just because we are unlucky in terms of xblocks download order)these two parameters can be set at the CLI level