-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/*.zim files not included in release tarball #68
Comments
Also if we used different zim files we could make them much smaller...they're 33M right now. |
This will allow tests to pass from people/distributions (e.g. Debian) using the release tarball. Fixes #68.
I also think we should not include 33M of ZIM files for tests.
I think it's important we test with ZIM files not created with pylibzim but there are many small ones. We could have an longer test that downloads a larger ZIM file also if we think it's relevant. I think there were issues with large number of articles in the very early days of this. |
I'm in favour of downloading ZIM files if they are more than 100KB. |
With my Debian hat on:
Avoiding large ZIM files in the tarball would be nice too, but the other two are more important. |
Might also be worth looking at what ZIMs kiwix-lib is using: https://github.com/kiwix/kiwix-lib/tree/master/test/data. wikipedia_en_ray_charles_mini_2020-03.zim is ~550k which seems much more reasonable. |
The large ZIM files used for tests are not included in the release tarball because of their size. But we still want the tests to pass in that case, so skip if the file is missing. Fixes #68.
I created #76 as an alternative solution, it just skips those tests if the file is missing. |
If you download https://files.pythonhosted.org/packages/26/8e/201f1ed560f83f5fd4a87fe3ec52960d078f1a31c8f1670ac16cb92fe3a3/libzim-0.0.3.post0.tar.gz it's missing the two zim files in tests/ so the tests fail. I believe we need a MANIFEST.in file for this.
Also, from a licensing standpoint, it would be nice if we could use zim files with fully public domain content so then I don't have to keep track of the specific copyright status for Debian.
The text was updated successfully, but these errors were encountered: