-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies especially zimscraperlib 3.x #170
Conversation
Nota : CI is failing for now, we need to wait for merge + release of openzim/python-scraperlib#147 |
d52ac4c
to
ef7f87a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 7 7
Lines 984 1013 +29
Branches 229 215 -14
=====================================
- Misses 984 1013 +29 ☔ View full report in Codecov by Sentry. |
… computation of automatic description and long description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good ; see my suggested change before merging
The primary goal of this PR was to upgrade to zimscraperlib 3.x to benefit from VideoLowWebm preset v2.
However, while working on it, it became clear that other things had to be fixed / where low hanging fruits.
This PR will probably induce a v3 of the scraper, the fact that we now check metadata by default is clearly a breaking change.
Make some progress on #145
Fix #169
Fix #152
Fix #148
Changes