Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop --type setting #361

Closed
benoit74 opened this issue Oct 14, 2024 · 0 comments · Fixed by #372
Closed

Drop --type setting #361

benoit74 opened this issue Oct 14, 2024 · 0 comments · Fixed by #372

Comments

@benoit74
Copy link
Collaborator

We recently merged --type channel and --type user. I think we should go even further and simply remove the --type setting.

It means we currently have either --type channel or --type playlist. This --type parameter is however mostly useless because the ID we are passing are unique, we cannot confuse a playlist with a channel or a user or a handle.

It looks like it is often complex for the user to properly set this setting.

I think we could hence simply drop this --type setting and try to guess which type of --id has been passed, we could always consider the ID passed with --id can be a channel, a user, a handle or a playlist, and test the 4 possibilities in a row.

This would help save lots of headaches to our users and it takes very little time to test the 4 possibilities in a row.

For backward compatibility reasons, the --type parameter should be kept until next major, but should simply be ignored,

I didn't check how easy this is to implement (we have maybe special flow when --type playlist is used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant