Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxy fields to host.vN config types #653

Merged
merged 2 commits into from
Jun 1, 2024
Merged

add proxy fields to host.vN config types #653

merged 2 commits into from
Jun 1, 2024

Conversation

scareything
Copy link
Member

No description provided.

@scareything scareything requested a review from a team as a code owner May 29, 2024 15:48
@@ -128,6 +128,10 @@ XX(protocol, string, none, protocol, __VA_ARGS__) \
XX(hostname, string, none, hostname, __VA_ARGS__) \
XX(port, int, none, port, __VA_ARGS__)

#define ZITI_PROXY_SERVER_MODEL(XX, ...) \
XX(address, string, none, address, __VA_ARGS__) \
XX(type, string, none, type, __VA_ARGS__)
Copy link
Member

@ekoby ekoby May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this an Enum -- there is only a handful of values that are valid or supported

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should to release-1.x, right?

@scareything scareything changed the base branch from main to release-1.x May 31, 2024 18:59
@ekoby ekoby merged commit 6184726 into release-1.x Jun 1, 2024
3 checks passed
@ekoby ekoby deleted the hostv1.proxy branch June 1, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants