when using ottca enrollment er->cert is null and segfaults on strlen

[dovholuknf]

fixes ottca enrollment

build release-1.x/main- run the steps below - observe segfault
rebuild this branch - run the steps below - observe success and head -5 clint.json will show cert/key being paths in the identity file

steps:

# build ...
sampleEnroller="$(find . -type f -name "sample_enroll" -executable)"

# Define variables
caName="my-third-party-ca"
zitiUser="admin"
zitiPwd="admin"
zitiCtrl="localhost:1280"

# Login to Ziti
ziti edge login $zitiCtrl -u $zitiUser -p $zitiPwd -y

# Define the PKI root directory
zitiPkiRoot="${PWD}"

# Remove the directory recursively
rm -rf ${zitiPkiRoot}/pki/


# Create a CA
ziti pki create ca --pki-root "${zitiPkiRoot}" --ca-file "$caName"
rootCa=$(find . -name "${caName}.cert" -print -quit)

# Create the CA on the Ziti controller
ziti edge create ca "$caName" "$rootCa" --auth --ottca

# Get the verification token
verificationToken=$(ziti edge list cas -j | jq -r ".data | map(select(.name == \"$caName\"))[0].verificationToken")

# Create a client certificate
ziti pki create client --pki-root "${zitiPkiRoot}" --ca-name "$caName" --client-file "$verificationToken" --client-name "$verificationToken"
verificationCert=$(find . -name "${verificationToken}.cert" -print -quit)

# Verify the CA
ziti edge verify ca $caName --cert $verificationCert

# Create a new user
newUser="clint"
ziti edge delete identity "$newUser"
newUserName="clint-cn"
ziti pki create client --pki-root "${zitiPkiRoot}" --ca-name "$caName" --client-file "$newUser" --client-name "$newUserName"
newUserCert=$(find . -name "${newUser}.cert" -print -quit)
newUserKey=$(find . -name "${newUser}.key" -print -quit)
ziti edge create identity $newUser --external-id "$newUserName"

# Create an OTT enrollment for the new user
ziti edge create enrollment ottca $newUser $caName

# Get the OTTCA JWT
ottcajwt=$(ziti edge list identities "name contains \"$newUser\"" -j | jq -r '.data[].enrollment.ottca.jwt')

# Write the JWT to a file without a newline at the end
echo -n "$ottcajwt" > "${newUser}.jwt"

# Remove the JSON file
rm "${newUser}.json"

$sampleEnroller "${newUser}.jwt" "${newUser}.json" $newUserKey $newUserCert

[qrkourier]

Potentially-related issues:

• ZET issue where ottca wasn't working then started working and (auto) ca still fails: autoca enrollment fails ziti-tunnel-sdk-c#840

• ZET issue where segfault occurs if --name isn't used with (auto) ca enrollment: enroll segfault with external CA ziti-tunnel-sdk-c#680