Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Address install plan upgrade with deprecated CRD flake #3386

Merged

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
The upgrade flow is tested by:

  1. Creating a bundle which owns v1alpha1 of its CRD, which is the version served
  2. Creating a subscription to the package and installing the first bundle
  3. Updating the catalog by adding the next version: v1alpha2 (served), v1alpha1 (not served)
  4. After the install plan installs the new CRD, the old CSV goes from Succeeded -> Failed -> Pending because v1alpha1 is no longer served
  5. The new CSV expects the old CSV to be in a Replacing state, which it isn't

Trying to address this issue by adding a replacement check to the pending state on the CSV phase graph to kick it into Replacing.

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2024
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva changed the title [WIP] 🐛 Address install plan upgrade with deprecated CRD flake 🐛 Address install plan upgrade with deprecated CRD flake Sep 5, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2024
@kevinrizza kevinrizza added this pull request to the merge queue Sep 5, 2024
Merged via the queue into operator-framework:master with commit a273449 Sep 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants