Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --version flag #3428

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix --version flag #3428

merged 1 commit into from
Nov 1, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 1, 2024

Description of the change:

Fixes --version flag

Motivation for the change:

Our build scripts had regression: we were not passing version information to go build correctly.

As a result running the binary with --version was not printing version and commit sha:

OLM version:
git commit:

Architectural changes:

Only build script changes to fix regression.

Testing remarks:

OLM binary should print build information when running with --version flag.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

/kind bug

@m1kola
Fix --version flag
d58412d 
Our build scripts had regression: we were not passing version
information to `go build` correctly.

As a result running the binary with `--version` was not printing
version and commit sha:

```
OLM version:
git commit:
```

Signed-off-by: Mikalai Radchuk <[email protected]>
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 1, 2024
tmshort
tmshort approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2024
@tmshort tmshort added this pull request to the merge queue Nov 1, 2024
Merged via the queue into operator-framework:master with commit fb6694f Nov 1, 2024
12 checks passed
@m1kola m1kola mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmshort tmshort tmshort approved these changes

@dtfranz dtfranz Awaiting requested review from dtfranz

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@tmshort tmshort

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1kola @tmshort